You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
removing commented-out lines, e.g. models in pytest.mark.parametrize calls, or at least explaining why they're commented out
avoiding aliasing the tmp_path variable as output_folder in tests.
I imagine that we'd have a PR that just addresses these kinds of changes without changing any other functionality, to ease verification that the tests are still correct.
The text was updated successfully, but these errors were encountered:
As raised by @d33bs in #62 (comment) and #62 (comment), the tests have a few areas where they could be simplified or improved.
Some suggestions were:
pytest.mark.parametrize
calls, or at least explaining why they're commented outtmp_path
variable asoutput_folder
in tests.I imagine that we'd have a PR that just addresses these kinds of changes without changing any other functionality, to ease verification that the tests are still correct.
The text was updated successfully, but these errors were encountered: