Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: luvit/luv
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.48.0-1
Choose a base ref
...
head repository: luvit/luv
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.48.0-2
Choose a head ref
  • 8 commits
  • 9 files changed
  • 1 contributor

Commits on Mar 1, 2024

  1. Fix garbage collection of scandir reqs

    Return a userdata wrapper around the uv_req_t to allow it to be garbage collected before the program exits. Previously, the returned userdata held a reference to itself in the Lua registry, meaning it would never be able to be garbage collected until the process ended.
    
    This reverts commit 0e4a895, which attempted a workaround for the same underlying problem that introduced a use-after-free.
    squeek502 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3e39f98 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Pass -fno-sanitize-recover=all to make all UBSan detections fatal

    From the clang docs:
    
    > By default, non-fatal checks are those enabled by UndefinedBehaviorSanitizer, except for -fsanitize=return and -fsanitize=unreachable.
    squeek502 committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    d6628b4 View commit details
    Browse the repository at this point in the history
  2. Fix undefined behavior in thread.c

    This was doing pointer addition where i could be >= LUV_THREAD_MAXNUM_ARG and then subtracting afterwards. By doing the subtraction first, the number is properly bounded within 0..LUV_THREAD_MAXNUM_ARG
    squeek502 committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    a290979 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    549a093 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    343b51b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec6ecf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4b80697 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #696 from squeek502/scandir-gc

    Fix garbage collection of scandir reqs
    squeek502 authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    7233e6d View commit details
    Browse the repository at this point in the history
Loading