Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use @std/tar #76

Merged
merged 4 commits into from
Sep 20, 2024
Merged

refactor: use @std/tar #76

merged 4 commits into from
Sep 20, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 16, 2024

There's other use of @std/archive within the codebase. This PR just deals with untarring a downloaded file in bundle/wasm/bundle.ts.

Towards denoland/std#5986

@lowlighter lowlighter mentioned this pull request Sep 19, 2024
Open
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 19, 2024

deno task test is blocked on denoland/deno#25736

@lowlighter
Copy link
Owner

Seems ci is failing because lockfile was upgraded to v4 but deno v1 doesn't support it I think:

error: Unsupported lockfile version '4'. Try upgrading Deno or recreating the lockfile at '/home/runner/work/libs/libs/bundle/deno.lock'.

@lowlighter lowlighter merged commit df4b902 into lowlighter:main Sep 20, 2024
77 checks passed
@lowlighter
Copy link
Owner

Thanks for taking the time to migrate this before deprecating the @std/archive !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @lowlighter