ringbuffer: fix rb_get_bytes_used (modulo overflow) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How I can find ts stream url? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the modulo to wrap around the buffer is unsafe because it's easy to have the values overflowing.
A simple "real" example from my debug:
Buffer size is 15Mb (15728640)
Pointer values:
tail=0x7f4b84c3b841 head=0x7f4b85b267e9
tail - head = -15642536
tail - head + buf_size = 86104 (correct)
(tail - head) % buf_size = 1134680 (wrong)
This "might" fix #3
PS:
I just got a DVB-C modulator card (with 4 modulators) and I'm testing it with this tool and will try to enhance it.
But I see that this repo isn't updated for quite some time so I'm not sure if you're really interested in PR's...