Skip to content

Commit 3b7e287

Browse files
author
John Plaisted
authored
doc: Clean up RFC docs from old repo. (#19)
1 parent ab8be63 commit 3b7e287

File tree

7 files changed

+21
-325
lines changed

7 files changed

+21
-325
lines changed

docs/rfc.md

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# DataHub RFC
1+
# GMA RFC
22

33
## What is an RFC?
44

@@ -23,17 +23,17 @@ An RFC goes through the following stages:
2323
- _Landed_: when an RFC's proposed changes are shipped in an actual release.
2424
- _Rejected_: when an RFC PR is closed without being merged.
2525

26-
[Pending RFC List](https://github.com/linkedin/datahub/pulls?q=is%3Apr+is%3Aopen+label%3Arfc+)
26+
[Pending RFC List](https://github.com/linkedin/datahub-gma/pulls?q=is%3Apr+is%3Aopen+label%3Arfc+)
2727

2828
## When to follow this process
2929

30-
You need to follow this process if you intend to make "substantial" changes to any components in the DataHub git repo,
31-
their documentation, or any other projects under the purview of the DataHub core teams. What constitutes a "substantial"
32-
change is evolving based on community norms, but may include the following:
30+
You need to follow this process if you intend to make "substantial" changes to any components in the GMA git repo, their
31+
documentation, or any other projects under the purview of the GMA core teams. What constitutes a "substantial" change is
32+
evolving based on community norms, but may include the following:
3333

3434
- A new feature that creates new API surface area, and would require a feature flag if introduced.
3535
- The removal of features that already shipped as part of the release channel.
36-
- The introduction of new idiomatic usage or conventions, even if they do not include code changes to DataHub itself.
36+
- The introduction of new idiomatic usage or conventions, even if they do not include code changes to GMA itself.
3737

3838
Some changes do not require an RFC:
3939

@@ -53,10 +53,10 @@ pull request with the specific implementation design. We also highly recommend s
5353

5454
## The process
5555

56-
In short, to get a major feature added to DataHub, one must first get the RFC merged into the RFC repo as a markdown
57-
file. At that point the RFC is 'active' and may be implemented with the goal of eventual inclusion into DataHub.
56+
In short, to get a major feature added to GMA, one must first get the RFC merged into the RFC repo as a markdown file.
57+
At that point the RFC is 'active' and may be implemented with the goal of eventual inclusion into GMA.
5858

59-
- Fork the DataHub repository.
59+
- Fork the GMA repository.
6060
- Copy the `000-template.md` template file to `docs/rfc/active/000-my-feature.md`, where `my-feature` is more
6161
descriptive. Don't assign an RFC number yet.
6262
- Fill in the RFC. Put care into the details. _RFCs that do not present convincing motivation, demonstrate understanding
@@ -66,22 +66,22 @@ file. At that point the RFC is 'active' and may be implemented with the goal of
6666
- Update the pull request to add the number of the PR to the filename and add a link to the PR in the header of the RFC.
6767
- Build consensus and integrate feedback. RFCs that have broad support are much more likely to make progress than those
6868
that don't receive any comments.
69-
- Eventually, the DataHub team will decide whether the RFC is a candidate for inclusion.
69+
- Eventually, the GMA team will decide whether the RFC is a candidate for inclusion.
7070
- RFCs that are candidates for inclusion will entire a "final comment period" lasting 7 days. The beginning of this
7171
period will be signaled with a comment and tag on the pull request. Furthermore, an announcement will be made in the
7272
\#rfc Slack channel for further visibility.
73-
- An RFC acan be modified based upon feedback from the DataHub team and community. Significant modifications may trigger
74-
a new final comment period.
75-
- An RFC may be rejected by the DataHub team after public discussion has settled and comments have been made summarizing
76-
the rationale for rejection. The RFC will enter a "final comment period to close" lasting 7 days. At the end of the
77-
"FCP to close" period, the PR will be closed.
73+
- An RFC acan be modified based upon feedback from the GMA team and community. Significant modifications may trigger a
74+
new final comment period.
75+
- An RFC may be rejected by the GMA team after public discussion has settled and comments have been made summarizing the
76+
rationale for rejection. The RFC will enter a "final comment period to close" lasting 7 days. At the end of the "FCP
77+
to close" period, the PR will be closed.
7878
- An RFC author may withdraw their own RFC by closing it themselves. Please state the reason for the withdrawal.
79-
- An RFC may be accepted at the close of its final comment period. A DataHub team member will merge the RFC's associated
79+
- An RFC may be accepted at the close of its final comment period. A GMA team member will merge the RFC's associated
8080
pull request, at which point the RFC will become 'active'.
8181

8282
## Details on Active RFCs
8383

84-
Once an RFC becomes active then authors may implement it and submit the feature as a pull request to the DataHub repo.
84+
Once an RFC becomes active then authors may implement it and submit the feature as a pull request to the GMA repo.
8585
Becoming 'active' is not a rubber stamp, and in particular still does not mean the feature will ultimately be merged; it
8686
does mean that the core team has agreed to it in principle and are amenable to merging it.
8787

@@ -111,9 +111,9 @@ track the status of the RFC, please make one final PR to move the RFC from `docs
111111

112112
## Reviewing RFCs
113113

114-
Most of the DataHub team will attempt to review some set of open RFC pull requests on a regular basis. If a DataHub team
115-
member believes an RFC PR is ready to be accepted into active status, they can approve the PR using GitHub's review
116-
feature to signal their approval of the RFCs.
114+
Most of the GMA team will attempt to review some set of open RFC pull requests on a regular basis. If a GMA team member
115+
believes an RFC PR is ready to be accepted into active status, they can approve the PR using GitHub's review feature to
116+
signal their approval of the RFCs.
117117

118-
_DataHub's RFC process is inspired by many others, including [Vue.js](https://github.com/vuejs/rfcs) and
118+
_GMA's RFC process is inspired by many others, including [Vue.js](https://github.com/vuejs/rfcs) and
119119
[Ember](https://github.com/emberjs/rfcs)._

docs/rfc/active/1778-dashboards/README.md

Lines changed: 0 additions & 132 deletions
This file was deleted.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)