migrate url.ts to do-not-use folder because YOU SHOULD NOT USE IT!

vrichard · vrichard · commit ed3f0fb53d10 · 2018-03-12T17:06:45.000+01:00
diff --git a/do-not-use/url.js b/do-not-use/url.js
@@ -31,13 +31,14 @@ else {
 }
 /**
  * Encodes a path segment.
- * RFC 3986 reserves !, ', (, ), and * as well, but we only escape space,
- * like the implementations we are polyfilling.
+ * RFC 3986 reserves !, ', (, ), and * and the implementation pipes the
+ * output of encodeURIComponent to a hex encoding pass for these special
+ * characters.
  */
 function encodePathSegment(segment) {
-  return segment.replace(/ /g, function (c) {
-    return '%' + c.charCodeAt(0).toString(16)
-  });
+    return encodeURIComponent(segment).replace(/[!'()*]/g, function (c) {
+        return '%' + c.charCodeAt(0).toString(16);
+    });
 }
 var URLSearchParams = /** @class */ (function () {
     function URLSearchParams(init) {
@@ -142,18 +143,11 @@ var URL = /** @class */ (function () {
                 password: baseParts.password,
                 hostname: baseParts.hostname,
                 port: baseParts.port,
+                path: urlParts.path || baseParts.path,
                 query: urlParts.query || baseParts.query,
                 hash: urlParts.hash,
             };
         }
-        if (!urlParts.path) {
-          this.pathname = baseParts.path;
-        } else if (urlParts.path[0] !== '/') {
-          // relative path
-          this.pathname = baseParts.path + '/' + urlParts.path;
-        } else {
-          this.pathname = urlParts.path
-        }
         // console.log(URL.parse(base), URL.parse(url), this._parts);
     }
     URL.init = function () {
@@ -257,16 +251,12 @@ var URL = /** @class */ (function () {
             return this._parts.path ? this._parts.path : '/';
         },
         set: function (value) {
-            value = value.toString().split('/');
-            for (var i = 0; i < value.length; i++) {
-              value[i] = encodePathSegment(value[i])
-            }
-            if (value[0]) {
-              // ensure joined string starts with slash.
-              value.unshift('')
+            var chunks = value.toString().split('/').map(encodePathSegment);
+            if (chunks[0]) {
+                // ensure joined string starts with slash.
+                chunks.unshift('');
             }
-            value = value.join('/');
-            this._parts.path = value;
+            this._parts.path = chunks.join('/');
         },
         enumerable: true,
         configurable: true
diff --git a/do-not-use/url.ts b/do-not-use/url.ts
diff --git a/tests/test-url-class.ts b/tests/test-url-class.ts
@@ -1,6 +1,6 @@
 const originalURL = window.URL;
 
-import { URL, URLSearchParams } from '../url';
+import { URL, URLSearchParams } from '../do-not-use/url';
 
 const test = () => {
   let a = new originalURL('?fr=yset_ie_syc_oracle&type=orcl_hpset#page0', 'https://username:password@www.yahoo.com:80/path');
