Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

distinct wildcard addresses are conflated. #60

Open
pgte opened this issue Dec 1, 2017 · 1 comment
Open

distinct wildcard addresses are conflated. #60

pgte opened this issue Dec 1, 2017 · 1 comment
Labels
bug difficulty:moderate help wanted P2 - Medium ready

Comments

@pgte
Copy link
Contributor

pgte commented Dec 1, 2017

When two wildcard addresses are im the multiaddresses and they use wildcard address and port, they are deemed as the same in peerInfo.multiaddrs.distinct(), only one of them being returned.

For instance,

/ip4/0.0.0.0/tcp/0 is conflated with /ip4/0.0.0.0/tcp/0/some-other-transport because the tranport and port are the same, but really 0 here signifies "any port" and should lead to distinct addresses.
pgte referenced this issue in libp2p/js-libp2p Dec 1, 2017
@pgte
tests: testing multiaddress trim leaves relevant addresses untouched
5936229
@pgte
Copy link
Contributor Author

pgte commented Dec 1, 2017

Clarification: the conflation happens because of the wildcard port, not IP address.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug difficulty:moderate help wanted P2 - Medium ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgte @daviddias