Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Resolves #11119: Add iOS Dark Icon #11460

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

itzTheMeow
Copy link
Contributor

@itzTheMeow itzTheMeow commented Dec 3, 2024

Resolves #11119.

Implements the dark icon for iOS 18, and converts the AppIcon asset to use the "Single Size" format rather than "All Sizes (Xcode 13)" format.
I tested the icon on the iPhone 16 simulator and it becomes dark and tinted properly.

@itzTheMeow itzTheMeow changed the title iOS: Resolves #11119: iOS: Resolves #11119: Add iOS Dark Icon Dec 3, 2024
@laurent22
Copy link
Owner

Thanks for the PR. I haven't reviewed yet but would you mind sharing screenshots of how it would be with this change?

@itzTheMeow
Copy link
Contributor Author

simulator_screenshot_2469D6C8-7FD7-42DD-93CA-E8F175C43183
simulator_screenshot_D171843C-FF05-4ED1-B08C-CF276E444C14
simulator_screenshot_CA60C8E5-C9C3-424E-8595-32CB0CD2DCD5

Comment on lines +4 to +10
<dict>
<key>com.apple.security.application-groups</key>
<array>
<string>group.net.cozic.joplin</string>
</array>
</dict>
</plist>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this whitespace change

@@ -1776,4 +1776,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 11a2f8ebab99f816b8905858bff8a86a196b1f7e

COCOAPODS: 1.16.1
COCOAPODS: 1.16.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this I assume is not needed

Comment on lines +4 to +10
<dict>
<key>com.apple.security.application-groups</key>
<array>
<string>group.net.cozic.joplin</string>
</array>
</dict>
</plist>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Comment on lines +1 to 5
import { fileExtension } from '@joplin/lib/path-utils';
import { copyFile, pathExists, readdir, readFile, writeFile } from 'fs-extra';
import { dirname } from 'path';
import { execCommand } from './tool-utils';
import { fileExtension } from '@joplin/lib/path-utils';
const md5File = require('md5-file');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please restore this. We try to restrict the commits to just what's needed to make reviewing, reverting and merging easier

@laurent22
Copy link
Owner

Thanks for the update. I see that you removed the icons of various sizes - those are no longer needed, even for older devices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the iOS 18 Dark icon
2 participants