-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Resolves #11119: Add iOS Dark Icon #11460
base: dev
Are you sure you want to change the base?
Conversation
Thanks for the PR. I haven't reviewed yet but would you mind sharing screenshots of how it would be with this change? |
<dict> | ||
<key>com.apple.security.application-groups</key> | ||
<array> | ||
<string>group.net.cozic.joplin</string> | ||
</array> | ||
</dict> | ||
</plist> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this whitespace change
@@ -1776,4 +1776,4 @@ SPEC CHECKSUMS: | |||
|
|||
PODFILE CHECKSUM: 11a2f8ebab99f816b8905858bff8a86a196b1f7e | |||
|
|||
COCOAPODS: 1.16.1 | |||
COCOAPODS: 1.16.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this I assume is not needed
<dict> | ||
<key>com.apple.security.application-groups</key> | ||
<array> | ||
<string>group.net.cozic.joplin</string> | ||
</array> | ||
</dict> | ||
</plist> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
import { fileExtension } from '@joplin/lib/path-utils'; | ||
import { copyFile, pathExists, readdir, readFile, writeFile } from 'fs-extra'; | ||
import { dirname } from 'path'; | ||
import { execCommand } from './tool-utils'; | ||
import { fileExtension } from '@joplin/lib/path-utils'; | ||
const md5File = require('md5-file'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please restore this. We try to restrict the commits to just what's needed to make reviewing, reverting and merging easier
Thanks for the update. I see that you removed the icons of various sizes - those are no longer needed, even for older devices? |
Resolves #11119.
Implements the dark icon for iOS 18, and converts the AppIcon asset to use the "Single Size" format rather than "All Sizes (Xcode 13)" format.
I tested the icon on the iPhone 16 simulator and it becomes dark and tinted properly.