Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1804 - When tool is a method without parameters, the handling of parameters in ToolSpecification will result in an error. #1812

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix for issue #1804 - When tool is a method without parameters, the handling of parameters in ToolSpecification will result in an error. #1812

merged 2 commits into from
Sep 23, 2024

Conversation

bidek
Copy link
Contributor

@bidek bidek commented Sep 20, 2024

Issue

Fixes #1804

Change

Handling case when tool don`t have parameters.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added my new module in the BOM

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

bidek and others added 2 commits September 20, 2024 19:25
langchain4j
langchain4j approved these changes Sep 23, 2024
View reviewed changes
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bidek thank you!

@langchain4j langchain4j merged commit bcfaf73 into langchain4j:main Sep 23, 2024
1 of 6 checks passed
@bidek bidek deleted the fix/1804_When-tool-is-a-method-without-parameters branch September 23, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langchain4j langchain4j langchain4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] When tool is a method without parameters, the handling of parameters in ToolSpecification will result in an error.
2 participants
@bidek @langchain4j