Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

42 arch me brah #43

Merged
merged 2 commits into from
May 3, 2024
Merged

42 arch me brah #43

merged 2 commits into from
May 3, 2024

Conversation

pirog
Copy link
Member

@pirog pirog commented May 3, 2024

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@pirog pirog linked an issue May 3, 2024 that may be closed by this pull request
Setup script not working for WSL2 #42
Closed
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for get-lando canceled.

Name Link
🔨 Latest commit a8fa76c
🔍 Latest deploy log https://app.netlify.com/sites/get-lando/deploys/6634f85a7ad1770008ec3ca4

@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for setup-lando ready!

Name Link
🔨 Latest commit a8fa76c
🔍 Latest deploy log https://app.netlify.com/sites/setup-lando/deploys/6634f85a8b2ddf00085cbe73
😎 Deploy Preview https://deploy-preview-43--setup-lando.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 61 (🔴 down 4 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pirog pirog merged commit 912aa7b into main May 3, 2024
140 checks passed
@pirog pirog deleted the 42-arch-me-brah branch May 3, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup script not working for WSL2
1 participant
@pirog