Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download New Episodes for Favorite Shows #14

Open
Sneagan opened this issue May 16, 2019 · 4 comments
Open

Download New Episodes for Favorite Shows #14

Sneagan opened this issue May 16, 2019 · 4 comments

Comments

@Sneagan
Copy link
Contributor

Sneagan commented May 16, 2019

Is your feature request related to a problem? Please describe.
I'd like to have the ability to have the tool download the latest episode of all shows in a list of favorite episodes in the config whenever a sync is run.

Describe the solution you'd like
A new property in the config YAML will need to be added. I recommend an array of IDs:

---
podcasts:
  - id: 1
    ...
  - id: 2
    ...
favorites:
    - 1
    - 2

Additional context
This will probably require some significant refactoring of the download.go file. I'm happy to work on it if you're open to that.

@kvannotten
Copy link
Owner

What would you think of just adding a boolean value to each podcast called favorited or something? That would prevent issues with non-existent IDs.

@Sneagan
Copy link
Contributor Author

Sneagan commented May 16, 2019

That's a better idea. It also prevents the breaking up of information about an individual podcast into multiple sections. It keeps all the data about the show in one place. Much better.

Do you have any preferences about module structure? Is there a published pattern you're following that I can conform to if I take a pass at this?

@kvannotten
Copy link
Owner

Honestly, it's not too rigid. I'm trying to follow the cobra guidelines for the different commands. I'd also still like to have the program available as a library and the cli is just an interface on it. Other than that, just the general go stuff (gofmt), introduce as little dependencies as possible, ... Nothing too crazy :)

In any case: thanks for helping and enjoy ;)

@Sneagan
Copy link
Contributor Author

Sneagan commented May 16, 2019

Thanks for starting the project! Let me know if I hit out of scope features. You've done great stuff here and I think it could easily become a really powerful library, but I want to be respectful of your goals. I'm already tinkering with integrating it into my own podcast flow. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants