Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix duplicate logs and parameter wrong hints. #6086

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Chore: Fix duplicate logs and parameter wrong hints. #6086

merged 1 commit into from
Jun 6, 2023

Conversation

yanggangtony
Copy link
Contributor

Fix duplicate logs and parameter wrong hints.
企业微信截图_dbd0c58d-4862-4055-804d-5706e719413a

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -32.26 ⚠️

Comparison is base (85213e6) 66.43% compared to head (4d923bf) 34.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6086       +/-   ##
===========================================
- Coverage   66.43%   34.17%   -32.26%     
===========================================
  Files         191      189        -2     
  Lines       24662    24617       -45     
===========================================
- Hits        16383     8413     -7970     
- Misses       6689    15149     +8460     
+ Partials     1590     1055      -535     
Flag Coverage Δ
core-unittests ?
e2e-multicluster-test 31.00% <100.00%> (+0.05%) ⬆️
e2etests 33.43% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/app/server.go 55.77% <ø> (-5.61%) ⬇️
cmd/core/app/options/options.go 92.45% <100.00%> (ø)

... and 134 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Somefive Somefive merged commit 114cf40 into kubevela:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants