Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏫upgrade kustomize #55

Merged
merged 1 commit into from
Aug 23, 2019
Merged

⏫upgrade kustomize #55

merged 1 commit into from
Aug 23, 2019

Conversation

magicsong
Copy link

No description provided.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magicsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2019
@magicsong magicsong added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2019
@ks-ci-bot ks-ci-bot merged commit f5425a3 into openelb:master Aug 23, 2019
@magicsong magicsong deleted the ch branch August 23, 2019 16:05
- name: name
image: nginx:alpine
ports:
- containerPort: 80

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this file removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be just an example to explain how to use it, but if you want to know how to use it, you can refer to the documentation at the bottom of the doc directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README refers to this file which (on master) doesn't exist anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i see, thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants