Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[argocd] update argocd to v2.5.10 #9753

Merged
merged 1 commit into from
Feb 2, 2023
Merged

[argocd] update argocd to v2.5.10 #9753

merged 1 commit into from
Feb 2, 2023

Conversation

yanggangtony
Copy link
Member

@yanggangtony yanggangtony commented Feb 2, 2023 •
edited
Loading

Signed-off-by: yanggang [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR update argocd to version 2.5.10

[argocd] update argocd to v2.5.10

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2023
floryut
floryut approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanggangtony Thank you; So many version of argocd gets release though 😅
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yanggangtony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@yanggangtony
Copy link
Member Author

yanggangtony commented Feb 2, 2023 •
edited
Loading

@floryut
😅 hhha

@yanggangtony
Copy link
Member Author

@floryut
in recent days , i found kubespray is a very quick response and rapid develop projects.
so your suggestion is update the software's version at a lower frequency?

☺️☺️☺️
maybe i will deduce the frequency to follow the latest versions..

@oomichi
Copy link
Contributor

oomichi commented Feb 2, 2023

haha, I had the same feeling about argocd as @floryut :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit e8f048c into kubernetes-sigs:master Feb 2, 2023
@yanggangtony
Copy link
Member Author

Actuall ,Argo CD uses the semver versioning and ensures that following rules:
like :

The patch release does not introduce any breaking changes. So if you are upgrading from v1.5.1 to v1.5.3 there should be no special instructions to follow.

So it will no influence with current version to upgrade.
Maybe next time , i will reduce the frequency.😄
thanks for yours reviews.
@oomichi @floryut

@floryut
Copy link
Member

floryut commented Feb 6, 2023

@yanggangtony no worries, honnestly it doesn't bother me at all, at least you're keeping it up to date.

If you want to bump the minor at a lower frequency that's fine but you can keep the current pace if you want to, that's anyway appreciated! Thank you

HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@HoKim98
[argocd] update argocd to v2.5.10 (kubernetes-sigs#9753)
ad19f6b 
Signed-off-by: yanggang <[email protected]>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@nolimitkun
[argocd] update argocd to v2.5.10 (kubernetes-sigs#9753)
88e5067 
Signed-off-by: yanggang <[email protected]>
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@pedromcpedro
[argocd] update argocd to v2.5.10 (kubernetes-sigs#9753)
db397e2 
Signed-off-by: yanggang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@mzaian mzaian Awaiting requested review from mzaian

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanggangtony @k8s-ci-robot @oomichi @floryut