Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd arch can support arm64 and amd64 #9421

Merged
merged 1 commit into from
Oct 24, 2022
Merged

etcd arch can support arm64 and amd64 #9421

merged 1 commit into from
Oct 24, 2022

Conversation

yanggangtony
Copy link
Member

@yanggangtony yanggangtony commented Oct 22, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

etcd arch can now support arm64 and amd64

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2022
@oomichi
Copy link
Contributor

oomichi commented Oct 23, 2022

Nice catch

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2022
@yankay
Copy link
Member

yankay commented Oct 24, 2022

Thanks @yanggangtony

/lgtm

@yanggangtony
Copy link
Member Author

thanks @yankay , @oomichi, Its my pleasure

@oomichi
Copy link
Contributor

oomichi commented Oct 24, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, yanggangtony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit a84271a into kubernetes-sigs:master Oct 24, 2022
@oomichi oomichi added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2022
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@salifou
etcd arch can support arm64 and amd64 (kubernetes-sigs#9421)
3888b69
@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@enneitex
etcd arch can support arm64 and amd64 (kubernetes-sigs#9421)
00ad362
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@HoKim98
etcd arch can support arm64 and amd64 (kubernetes-sigs#9421)
30dd39f
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@nolimitkun
etcd arch can support arm64 and amd64 (kubernetes-sigs#9421)
1e97b70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanggangtony @k8s-ci-robot @oomichi @yankay