Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox image: add symlink for /bin/mkfifo #59268

Merged
merged 2 commits into from
Feb 3, 2018
Merged

busybox image: add symlink for /bin/mkfifo #59268

merged 2 commits into from
Feb 3, 2018

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Feb 2, 2018

This makes the bazel image more similar to the bash build, which uses
the image from the docker registry.

mkfifo is used by e.g. kops to send logs to both a /var/log file and to
stdout (which is then captured by docker).

Add /bin/mkfifo symlink to bazel build for busybox, so that CI builds have /bin/tee

@justinsb
busybox image: add symlink for /bin/mkfifo
eeb8666 
This makes the bazel image more similar to the bash build, which uses
the image from the docker registry.

mkfifo is used by e.g. kops to send logs to both a /var/log file and to
stdout (which is then captured by docker).
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 2, 2018
@k8s-ci-robot k8s-ci-robot requested review from ixdy and lavalamp February 2, 2018 14:48
@justinsb justinsb mentioned this pull request Feb 2, 2018
Closed
@justinsb
Copy link
Member Author

justinsb commented Feb 2, 2018

This addresses #59263. Note this is only against the 1.7 branch, and I believe this image is only used by CI (not by our releases). In 1.8 we switched how the image was built, so it doesn't need to be applied to 1.8+ (in fact, it can't be IIRC)

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 2, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2018

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2018
@wojtek-t wojtek-t added this to the v1.7 milestone Feb 2, 2018
@justinsb
Copy link
Member Author

justinsb commented Feb 2, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2018

@justinsb - it seems it didn't fix the problem - kops presubmit is still failing with this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2018
@justinsb justinsb force-pushed the add_mkfifo_symlink_17 branch from 55f0391 to 5eb5599 Compare February 3, 2018 05:47
@justinsb
Force creation of /tmp directory in busybox image
19e23a0 
We create a symlink to hostname, to force creation of the /tmp
directory.  There doesn't seem to be a direct way of creating a
directory in the docker_build task in bazel.
@justinsb justinsb force-pushed the add_mkfifo_symlink_17 branch from 5eb5599 to 19e23a0 Compare February 3, 2018 05:57
@justinsb
Copy link
Member Author

justinsb commented Feb 3, 2018

Had to add a symlink under /tmp, to force creation of the /tmp directory (in which we are creating that FIFO pipe). I don't love it, but it seems the least-bad option that I came up with. This should only be used for the bazel CI image for 1.7, as the release version uses a "real" docker image and we pull that base image from 1.8 for bazel.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 82dacd0 into kubernetes:release-1.7 Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy Awaiting requested review from ixdy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@justinsb @wojtek-t @k8s-ci-robot @fejta-bot @k8s-github-robot