Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --retry-connrefused to all curl invocations if available. #57394

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Add --retry-connrefused to all curl invocations if available. #57394

merged 1 commit into from
Dec 19, 2017

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Dec 19, 2017 •
edited by wojtek-t
Loading

By default 'Connection refused' error is not a transient error
and is not retried.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Retry 'connection refused' errors when setting up clusters on GCE.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2017
@mborsz
Copy link
Member Author

mborsz commented Dec 19, 2017

/assign wojtek-t

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2017
@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 19, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 19, 2017
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@mborsz
Copy link
Member Author

mborsz commented Dec 19, 2017

/retest

@mborsz mborsz mentioned this pull request Dec 19, 2017
Merged
@wojtek-t wojtek-t removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@mborsz
Add --retry-connrefused to all curl invocations.
95dccb4 
By default 'Connection refused' error is not a transient error
and is not retried.
@mborsz
Copy link
Member Author

mborsz commented Dec 19, 2017

PTAL

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit bf12b51 into kubernetes:master Dec 19, 2017
This was referenced Dec 20, 2017
Merged
Merged
@mborsz mborsz mentioned this pull request Dec 20, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 20, 2017
Merge pull request #57401 from mborsz/automated-cherry-pick-of-#57394…
0216274 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #57394: Add --retry-connrefused to all curl invocations.

Cherry pick of #57394 on release-1.7.

#57394: Add --retry-connrefused to all curl invocations.
wojtek-t added a commit that referenced this pull request Dec 20, 2017
@wojtek-t
Revert "Automated cherry pick of #57394: Add --retry-connrefused to a…
898f0cd 
…ll curl invocations."
wojtek-t added a commit that referenced this pull request Dec 20, 2017
@wojtek-t
Merge pull request #57454 from kubernetes/revert-57401-automated-cher…
dad80fa 
…ry-pick-of-#57394-upstream-release-1.7

Revert "Automated cherry pick of #57394: Add --retry-connrefused to all curl invocations."
jpbetz added a commit that referenced this pull request Dec 20, 2017
@jpbetz
Merge pull request #57449 from mborsz/automated-cherry-pick-of-#57394…
9e5be8d 
…-upstream-release-1.8

Automated cherry pick of #57394: Add --retry-connrefused to all curl invocations.
k8s-github-robot pushed a commit that referenced this pull request Dec 21, 2017
Merge pull request #57448 from mborsz/automated-cherry-pick-of-#57394…
1a2f53c 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #57394: Add --retry-connrefused to all curl invocations.

Cherry pick of #57394 on release-1.7.

#57394: Add --retry-connrefused to all curl invocations.
k8s-github-robot pushed a commit that referenced this pull request Dec 28, 2017
Merge pull request #57450 from mborsz/automated-cherry-pick-of-#57394…
2b3a9bd 
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57394: Add --retry-connrefused to all curl invocations.

Cherry pick of #57394 on release-1.9.

#57394: Add --retry-connrefused to all curl invocations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mborsz @wojtek-t @k8s-ci-robot @k8s-github-robot