Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduler cache panic when updating pod condition #56733

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Fix scheduler cache panic when updating pod condition #56733

merged 1 commit into from
Jan 4, 2018

Conversation

bsalamat
Copy link
Member

@bsalamat bsalamat commented Dec 2, 2017

What this PR does / why we need it:
This PR fixes an issue in the scheduler code which could cause a cache panic. More details are given in the referenced issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56730

Special notes for your reviewer:

Release note:

Fix scheduler cache panic when updating pod conditions.

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 2, 2017
@bsalamat
Copy link
Member Author

bsalamat commented Dec 2, 2017

@davidopp or @timothysc Could one of you guys add 1.7 milestone to this PR please?

@davidopp davidopp added this to the v1.7 milestone Dec 14, 2017
@timothysc timothysc added approved-for-milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 14, 2017
timothysc
timothysc suggested changes Dec 14, 2017
View reviewed changes
plugin/pkg/scheduler/scheduler.go Outdated
@@ -270,16 +270,21 @@ func (sched *Scheduler) scheduleOne() {

// Tell the cache to assume that a pod now is running on a given node, even though it hasn't been bound yet.
// This allows us to keep scheduling without waiting on binding to occur.
assumedPod := *pod
podCopy, err := api.Scheme.DeepCopy(pod)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment to why you are doing this, it's totally non-obvious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kubernetes kubernetes deleted a comment from k8s-github-robot Dec 16, 2017
@bsalamat
Copy link
Member Author

/retest

@bsalamat
Copy link
Member Author

@timothysc or @davidopp could one of you lgtm this? I think we should merge this ASAP.

@wojtek-t
Copy link
Member

wojtek-t commented Jan 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2018
timothysc
timothysc approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, timothysc, wojtek-t

Associated issue: #56730

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@wojtek-t
Copy link
Member

wojtek-t commented Jan 4, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 1133ada into kubernetes:release-1.7 Jan 4, 2018
@bsalamat bsalamat deleted the cache_panic_fix_17 branch November 28, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

Assignees

@timothysc timothysc

@davidopp davidopp

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@bsalamat @wojtek-t @k8s-ci-robot @fejta-bot @k8s-github-robot @timothysc @enisoc @davidopp