Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #56503 on 1.7 #56711

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Cherry pick of #56503 on 1.7 #56711

merged 1 commit into from
Dec 4, 2017

Conversation

php-coder
Copy link
Contributor

What this PR does / why we need it:
Cherry pick of #56503 (MustRunAsNonRoot should reject a pod if it has non-numeric USER) on release-1.7

Release note:

kubelet: fix bug where `runAsUser: MustRunAsNonRoot` strategy didn't reject a pod with a non-numeric `USER`.

CC @liggitt @tallclair @simo5

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 1, 2017
@cblecker
Copy link
Member

cblecker commented Dec 1, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2017
@enisoc enisoc added this to the v1.7 milestone Dec 2, 2017
@enisoc enisoc added status/approved-for-milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 2, 2017
@dims
Copy link
Member

dims commented Dec 4, 2017

/approve

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 4, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Dec 4, 2017

/approve no-issue

@wojtek-t
Copy link
Member

wojtek-t commented Dec 4, 2017

@liggitt - can you please lgtm if that looks fine to you?

@wojtek-t wojtek-t assigned liggitt and unassigned dchen1107 Dec 4, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2017
@liggitt
Copy link
Member

liggitt commented Dec 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, php-coder, wojtek-t

Associated issue: 56503

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 6c9b30e into kubernetes:release-1.7 Dec 4, 2017
@php-coder php-coder deleted the fail_non_root_verification_1.7 branch December 4, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@php-coder @cblecker @dims @wojtek-t @liggitt @k8s-github-robot @enisoc @dchen1107 @k8s-ci-robot