Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GRS, RAGRS storage account type support for azure disk #55931

Merged
merged 1 commit into from
Nov 20, 2017
Merged

add GRS, RAGRS storage account type support for azure disk #55931

merged 1 commit into from
Nov 20, 2017

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Nov 17, 2017 •
edited by jpbetz
Loading

What this PR does / why we need it:
add Standard_GRS, Standard_RAGRS storage account type support for azure disk, and Standard_ZRS, Premium_GRS are not supported for azure disk now

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #55774

Special notes for your reviewer:

Release note:

Add Standard_GRS, Standard_RAGRS support for azure disk

/sig azure
@rootfs @brendanburns

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/azure size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2017
@andyzhangx andyzhangx changed the title add GRS, RAGRS support for azure disk add GRS, RAGRS storage account type support for azure disk Nov 17, 2017
@jsafrane
Copy link
Member

/unassign
/assign @colemickens @brendanburns

@k8s-ci-robot
Copy link
Contributor

@jsafrane: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members can be assigned.

In response to this:

/unassign
/assign @colemickens @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Member

@colemickens, can you please add more azure-aware people to OWNERS as reviewers? I've no clue what GRS means.

@colemickens
Copy link
Contributor

(Brendan's username has the d in the middle)

cc: @jdumars @seanknox @brendandburns @jackfrancis Not sure who is doing upstream work right now. Can whoever is go ahead and place themselves in the OWNERS file?

As FYI: "GRS" is "Geographically redundant storage". Azure Storage has different SKUs with different replication attributes, etc.

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members can be assigned.

In response to this:

/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/assign @brendandburns

@andyzhangx
Copy link
Member Author

Thx, I will put my name in the azure reviewer list.

@rootfs
Copy link
Contributor

rootfs commented Nov 20, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, rootfs

Associated issue: 55774

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55963, 55790, 55670, 55931). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 98fb71e into kubernetes:master Nov 20, 2017
This was referenced Nov 28, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 30, 2017
Merge pull request #56467 from andyzhangx/automated-cherry-pick-of-#5…
177543c 
…5931-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55931

Cherry pick of #55931 on release-1.8.

#55931: add Standard GRS, RAGRS support for azure disk
k8s-github-robot pushed a commit that referenced this pull request Nov 30, 2017
Merge pull request #56469 from andyzhangx/automated-cherry-pick-of-#5…
2f2ae73 
…5931-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #55931

Cherry pick of #55931 on release-1.7.

#55931: add Standard GRS, RAGRS support for azure disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@colemickens colemickens

@brendandburns brendandburns

@rootfs rootfs

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure disk: storage class should support the sku if the storage accout support it
8 participants
@andyzhangx @jsafrane @k8s-ci-robot @colemickens @rootfs @k8s-github-robot @brendandburns @msau42