Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix azure pv crash due to volumeSource.ReadOnly value nil #54607

Merged
merged 1 commit into from
Oct 26, 2017
Merged

fix azure pv crash due to volumeSource.ReadOnly value nil #54607

merged 1 commit into from
Oct 26, 2017

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 26, 2017 •
edited
Loading

What this PR does / why we need it:
kubelet in agent would crash due to volumeSource.ReadOnly is nil in some condition

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #54149, #55199

Special notes for your reviewer:
#54149 is the issue: volumeSource.ReadOnly is nil, make kubelet in azure agent node crash.
"volumeSource.ReadOnly is nil" could be regarded as false value
@rootfs

Release note:

fix azure pv crash due to volumeSource.ReadOnly value nil

/sig azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/azure size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2017
@rootfs
Copy link
Contributor

rootfs commented Oct 26, 2017

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, rootfs

Associated issue: 54149

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54593, 54607, 54539, 54105). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 189dfe0 into kubernetes:master Oct 26, 2017
This was referenced Oct 27, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 30, 2017
Merge pull request #54679 from andyzhangx/automated-cherry-pick-of-#5…
4421817 
…4607-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54607

Cherry pick of #54607 on release-1.8.

#54607: fix azure pv crash due to readOnly nil
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@andyzhangx andyzhangx mentioned this pull request Nov 7, 2017
Closed
k8s-github-robot pushed a commit that referenced this pull request Nov 13, 2017
Merge pull request #54678 from andyzhangx/automated-cherry-pick-of-#5…
46cc0ee 
…4607-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #54607

Cherry pick of #54607 on release-1.7.

#54607: fix azure pv crash due to readOnly nil
@andyzhangx andyzhangx deleted the azure-readonly-fix branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rootfs rootfs

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in azure_dd/azure_mounter.go when syncing pod
8 participants
@andyzhangx @rootfs @k8s-github-robot @fejta-bot @k8s-cherrypick-bot @brendandburns @k8s-ci-robot @msau42