Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlusterFS plugin fails to mount volumes #53292

Merged
merged 1 commit into from
Nov 19, 2017
Merged

GlusterFS plugin fails to mount volumes #53292

merged 1 commit into from
Nov 19, 2017

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Sep 30, 2017 •
edited by wojtek-t
Loading

Cherrypick of #52365

Signed-off-by: Humble Chirammal [email protected]

What this PR does / why we need it:

Which issue this PR fixes
fixes: #50463

Special notes for your reviewer:

Release note:

Fix bug in mounting volumes with GlusterFS plugin

@humblec
GlusterFS plugin fails to mount volumes
b6c155e 
Cherrypick of kubernetes#52365

Signed-off-by: Humble Chirammal <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2017
@humblec
Copy link
Contributor Author

humblec commented Sep 30, 2017

/assign @jsafrane

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 30, 2017
@humblec
Copy link
Contributor Author

humblec commented Sep 30, 2017

/test pull-kubernetes-e2e-gce-etcd3

@humblec
Copy link
Contributor Author

humblec commented Oct 1, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 1, 2017
@humblec
Copy link
Contributor Author

humblec commented Oct 2, 2017

@jsafrane Please review.

@jsafrane
Copy link
Member

jsafrane commented Oct 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jsafrane

Associated issue: 52365

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@humblec
Copy link
Contributor Author

humblec commented Oct 3, 2017

@caesarxuchao Can you please approve/merge this PR ?

@humblec
Copy link
Contributor Author

humblec commented Oct 11, 2017

/retest

@humblec
Copy link
Contributor Author

humblec commented Oct 11, 2017

/test pull-kubernetes-e2e-gce-bazel

1 similar comment
@humblec
Copy link
Contributor Author

humblec commented Oct 12, 2017

/test pull-kubernetes-e2e-gce-bazel

@humblec
Copy link
Contributor Author

humblec commented Oct 12, 2017

Looks to me a spurious failure.

@humblec
Copy link
Contributor Author

humblec commented Oct 12, 2017

/test pull-kubernetes-e2e-gce-bazel

1 similar comment
@humblec
Copy link
Contributor Author

humblec commented Oct 16, 2017

/test pull-kubernetes-e2e-gce-bazel

@humblec
Copy link
Contributor Author

humblec commented Oct 16, 2017

/test pull-kubernetes-unit

@humblec
Copy link
Contributor Author

humblec commented Nov 3, 2017

@jsafrane How to remove or who can remove do-not-merge%2Fcherry-pick-not-approved label ?

@jsafrane
Copy link
Member

jsafrane commented Nov 3, 2017

How to remove or who can remove do-not-merge%2Fcherry-pick-not-approved label ?

@wojtek-t is 1.7 release manager and must approve cherry picks

@humblec
Copy link
Contributor Author

humblec commented Nov 3, 2017

@jsafrane Thanks... @wojtek-t can you please approve this PR ?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 15, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 15, 2017
@wojtek-t wojtek-t removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 15, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Nov 15, 2017
@xiangpengzhao
Copy link
Contributor

/test pull-kubernetes-e2e-kubeadm-gce
/test pull-kubernetes-e2e-gce

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 05d9ad1 into kubernetes:release-1.7 Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@humblec @jsafrane @k8s-github-robot @xiangpengzhao @fejta-bot @wojtek-t @k8s-ci-robot