Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party resources should not be part of conformance #52823

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Third party resources should not be part of conformance #52823

merged 1 commit into from
Sep 25, 2017

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Sep 21, 2017 •
edited
Loading

They are alpha and were sunset and replaced by CRD.

Fixes #52822

Third Party Resource tests in the e2e suite were incorrectly marked as part of the conformance bucket.  They are alpha and are not required for conformance.

@smarterclayton
Third party resources should not be part of conformance
2c478b2 
They are alpha and were sunset and replaced by CRD.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2017
@smarterclayton
Copy link
Contributor Author

@kubernetes/sig-testing-pr-reviews I'm going through the 1.7 conformance tests and spotted this. @WilliamDenniss

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 21, 2017
@smarterclayton smarterclayton added this to the v1.7 milestone Sep 21, 2017
@smarterclayton smarterclayton added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2017
@smarterclayton
Copy link
Contributor Author

/retest

@bgrant0607
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, smarterclayton

Associated issue: 52822

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bgrant0607
Copy link
Member

@smarterclayton Is there a similar PR for master?

@smarterclayton
Copy link
Contributor Author

Already removed the test in master.

@smarterclayton
Copy link
Contributor Author

In master the third party resource is already gone, but CRD is part of conformance.

@smarterclayton
Copy link
Contributor Author

This needs sign off from the 1.7 release manager

@smarterclayton
Copy link
Contributor Author

@wojtek-t that's you if i can read a table right

@smarterclayton smarterclayton added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 25, 2017
@smarterclayton
Copy link
Contributor Author

Setting approved to unblock conformance testing on 1.7

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 25, 2017 •
edited
Loading

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 2c478b2 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a3af820 into kubernetes:release-1.7 Sep 25, 2017
@spiffxp spiffxp mentioned this pull request Oct 6, 2017
Closed
@timothysc timothysc mentioned this pull request Oct 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@smarterclayton @bgrant0607 @k8s-github-robot @k8s-ci-robot @pwittrock @saad-ali