Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluentd-gcp addon] Update event-exporter to address metrics problem #52263

Merged
merged 1 commit into from
Sep 12, 2017
Merged

[fluentd-gcp addon] Update event-exporter to address metrics problem #52263

merged 1 commit into from
Sep 12, 2017

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented Sep 11, 2017 •
edited
Loading

Follow-up of GoogleCloudPlatform/k8s-stackdriver#37:

In the clusters with CA, the number of metric streams will continuously grow if the host is included.

Name is updated b/c otherwise addon manager will not be able to pick up the change.

[fluentd-gcp addon] Bug with event-exporter leaking memory on metrics in clusters with CA is fixed.

@crassirostris crassirostris added area/logging release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Sep 11, 2017
@crassirostris crassirostris added this to the v1.8 milestone Sep 11, 2017
@crassirostris crassirostris requested a review from piosz September 11, 2017 08:10
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 11, 2017
@piosz
Copy link
Member

piosz commented Sep 11, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2017
@crassirostris crassirostris added the kind/bug Categorizes issue or PR as related to a bug. label Sep 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Associated issue requirement bypassed by: piosz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2017
@crassirostris
Copy link
Author

/retest

3 similar comments
@crassirostris
Copy link
Author

/retest

@crassirostris
Copy link
Author

/retest

@crassirostris
Copy link
Author

/retest

@crassirostris
Copy link
Author

Blocked on #52270

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52007, 52196, 52169, 52263, 52291)

@k8s-github-robot k8s-github-robot merged commit 4775dae into kubernetes:master Sep 12, 2017
@crassirostris crassirostris mentioned this pull request Sep 13, 2017
Merged
@crassirostris crassirostris added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 13, 2017
@wojtek-t wojtek-t modified the milestones: v1.7, v1.8 Sep 13, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 15, 2017
k8s-github-robot pushed a commit that referenced this pull request Sep 15, 2017
Merge pull request #52407 from crassirostris/automated-cherry-pick-of…
6a0ca0a 
…-#52263-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #52263

Cherry pick of #52263 on release-1.7.

#52263: Update event-exporter to address metrics

```release-note
[fluentd-gcp addon] Bug with event-exporter leaking memory on metrics in clusters with CA is fixed.
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@crassirostris crassirostris mentioned this pull request Sep 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz Awaiting requested review from piosz

Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@crassirostris @piosz @k8s-github-robot @fejta-bot @k8s-cherrypick-bot @wojtek-t @k8s-ci-robot