Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to Attach Volume fails for very first time on vSphere in 1.7 release #51217

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Attempt to Attach Volume fails for very first time on vSphere in 1.7 release #51217

merged 1 commit into from
Aug 25, 2017

Conversation

BaluDontu
Copy link
Contributor

@BaluDontu BaluDontu commented Aug 23, 2017 •
edited
Loading

Before every attach, vSphere cloud provider checks if the SCSI controller is present on the VM. If not present, it will try to create one and attach the disk to that SCSI controller on VM. If already present, it will use the SCSI controller.

For the very first time when SCSI controller is not present on the VM, we try to create one and retrieve the SCSI controller for the disk to created on that SCSI controller. But in release 1.7, after successful creation of SCSI controller, we are not assigning back the SCSI controller to the existing "scsicontroller" variable. Because of this the very first time, attach of the disk will fail.

This problem is not observed on master, as we have taken care of this in vSphere cloud provider refactoring - #49164

@luomiao @divyenpatel @rohitjogvmw

vSphere: Fix attach volume failing on the first try.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @BaluDontu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 23, 2017
@BaluDontu
Copy link
Contributor Author

@wojtek-t : This is observed only in 1.7 and 1.6 release branches. Can you verify and please approve it.

@BaluDontu BaluDontu mentioned this pull request Aug 23, 2017
Closed
@divyenpatel
Copy link
Member

lgtm

@BaluDontu BaluDontu changed the title Attempt to Attach Volume fails for very first time on vSphere Attempt to Attach Volume fails for very first time on vSphere in 1.7 release Aug 23, 2017
@luomiao
Copy link

luomiao commented Aug 23, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017
@luomiao
Copy link

luomiao commented Aug 23, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaluDontu, luomiao

Associated issue requirement bypassed by: luomiao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017
@BaluDontu
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@BaluDontu: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t
Copy link
Member

@BaluDontu - please add a (user-friendly) release note to this PR.

@wojtek-t wojtek-t added this to the v1.7 milestone Aug 24, 2017
@BaluDontu
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@BaluDontu: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 24, 2017
@BaluDontu
Copy link
Contributor Author

@wojtek-t : I have added the release note. I see needs-ok-test label still on PR. Also can you retry the failed tests.

@wojtek-t
Copy link
Member

/retest

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f3ecd68 into kubernetes:release-1.7 Aug 25, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@BaluDontu BaluDontu deleted the vSphereSCSIFix branch September 5, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

Assignees

@luxas luxas

@erictune erictune

@luomiao luomiao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@BaluDontu @k8s-ci-robot @divyenpatel @luomiao @k8s-github-robot @wojtek-t @k8s-cherrypick-bot @luxas @erictune