Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual cherry-pick of #50290 #50517

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Manual cherry-pick of #50290 #50517

merged 1 commit into from
Aug 12, 2017

Conversation

piosz
Copy link
Member

@piosz piosz commented Aug 11, 2017 •
edited by wojtek-t
Loading

Cherry pick of #50290 on release-1.7.
#50290: Added monitoring sidecar for Heapster

Collect metrics from Heapster in Stackdriver mode.

@piosz piosz added this to the v1.7 milestone Aug 11, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 11, 2017
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 11, 2017
@wojtek-t
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2017
@shyamjvs shyamjvs mentioned this pull request Aug 11, 2017
Closed
@piosz
Copy link
Member Author

piosz commented Aug 12, 2017

/test pull-kubernetes-e2e-gce-etcd3
/test pull-kubernetes-federation-e2e-gce

@piosz
Copy link
Member Author

piosz commented Aug 12, 2017

/test pull-kubernetes-federation-e2e-gce

@crassirostris
Copy link

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz, wojtek-t

Associated issue: 50290

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3c47c2c into kubernetes:release-1.7 Aug 12, 2017
@piosz piosz deleted the release-1.7 branch August 12, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crassirostris crassirostris

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@piosz @wojtek-t @crassirostris @k8s-github-robot @k8s-ci-robot