Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stackdriver event exporter version #50511

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Update Stackdriver event exporter version #50511

merged 1 commit into from
Aug 12, 2017

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented Aug 11, 2017 •
edited
Loading

Fixes #50510

fluentd-gcp addon: Fix a bug in the event-exporter, when repeated events were not sent to Stackdriver.

@crassirostris crassirostris added release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 11, 2017
@crassirostris crassirostris added this to the v1.8 milestone Aug 11, 2017
@crassirostris crassirostris requested a review from piosz August 11, 2017 10:10
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2017
piosz
piosz reviewed Aug 11, 2017
View reviewed changes
cluster/addons/fluentd-gcp/event-exporter.yaml
@@ -29,10 +29,11 @@ subjects:
apiVersion: apps/v1beta1
kind: Deployment
metadata:
name: event-exporter-v0.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will addona manager pick this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU yes, the old deployment will be deleted: https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/addon-manager

Addon will be deleted when its manifest file is deleted.

I think changing the name of the deployment is the same as removing the old addon and creating a new one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just manually checked and it indeed works correctly

@piosz
Copy link
Member

piosz commented Aug 11, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Associated issue: 50510

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50485, 49951, 50508, 50511, 50506)

@k8s-github-robot k8s-github-robot merged commit b0e066e into kubernetes:master Aug 12, 2017
@crassirostris crassirostris mentioned this pull request Aug 14, 2017
Merged
@crassirostris crassirostris added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 14, 2017
@wojtek-t wojtek-t modified the milestones: v1.7, v1.8 Aug 14, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 14, 2017
k8s-github-robot pushed a commit that referenced this pull request Aug 14, 2017
Merge pull request #50606 from crassirostris/automated-cherry-pick-of…
f39c608 
…-#50511-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #50511

Cherry pick of #50511 on release-1.7.

#50511: Update Stackdriver event exporter version

```release-note
fluentd-gcp addon: Fix a bug in the event-exporter, when repeated events were not sent to Stackdriver.
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz piosz left review comments

Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@crassirostris @piosz @k8s-github-robot @k8s-cherrypick-bot @wojtek-t @k8s-ci-robot