Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes kubernetes/kubeadm#347: empty node name when joining nodes with kubeadm #49825

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Fixes kubernetes/kubeadm#347: empty node name when joining nodes with kubeadm #49825

merged 1 commit into from
Aug 1, 2017

Conversation

erhudy
Copy link
Contributor

@erhudy erhudy commented Jul 29, 2017 •
edited by luxas
Loading

Node name discovery failed on kubeadm join. If a node name
is not explicitly provided, it will be looked up.

What this PR does / why we need it: kubeadm join fails because the preflight checks always see an empty node name. This corrects that issue.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes kubernetes/kubeadm#347

Special notes for your reviewer:

Release note:

kubeadm: Fix join preflight check false negative

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @erhudy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 29, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 29, 2017
@erhudy
Copy link
Contributor Author

erhudy commented Jul 31, 2017

/assign @luxas

@luxas
Copy link
Member

luxas commented Jul 31, 2017

/ok-to-test
/lgtm

Thanks @erhudy!

/assign @timothysc

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2017
@luxas luxas added this to the v1.7 milestone Jul 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erhudy, luxas

Associated issue: 347

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@luxas
Copy link
Member

luxas commented Jul 31, 2017

This PR replaces #49073

@erhudy
Copy link
Contributor Author

erhudy commented Jul 31, 2017

/test pull-kubernetes-verify

@erhudy
Fixes kubernetes/kubeadm#347
fea25a6 
Node name discovery failed on `kubeadm join`. If a node name
is not explicitly provided, it will be looked up.
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2017
@erhudy
Copy link
Contributor Author

erhudy commented Jul 31, 2017

/retest

@luxas luxas added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2017
@luxas
Copy link
Member

luxas commented Jul 31, 2017

/retest

@luxas luxas mentioned this pull request Jul 31, 2017
Merged
@luxas luxas added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 31, 2017
@luxas
Copy link
Member

luxas commented Jul 31, 2017

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@erhudy
Copy link
Contributor Author

erhudy commented Aug 1, 2017

/test pull-kubernetes-e2e-gce-etcd3

@erhudy
Copy link
Contributor Author

erhudy commented Aug 1, 2017

/retest

1 similar comment
@luxas
Copy link
Member

luxas commented Aug 1, 2017

/retest

@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 1, 2017
@luxas
Copy link
Member

luxas commented Aug 1, 2017

/retest

1 similar comment
@luxas
Copy link
Member

luxas commented Aug 1, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5ce3b35 into kubernetes:master Aug 1, 2017
@erhudy erhudy deleted the bugfix/kubeadm-337-empty-node-name branch August 1, 2017 12:18
k8s-github-robot pushed a commit that referenced this pull request Aug 1, 2017
Merge pull request #49893 from luxas/automated-cherry-pick-of-#49825-…
713e902 
…upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49825

Cherry pick of #49825 on release-1.7.

#49825: Fixes kubernetes/kubeadm#347
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@luxas luxas mentioned this pull request Aug 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@timothysc timothysc

@lukemarsden lukemarsden

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

kubeadm join failing preflight checks
10 participants
@erhudy @k8s-ci-robot @luxas @k8s-github-robot @fejta-bot @k8s-cherrypick-bot @justinsb @timothysc @lukemarsden @wojtek-t