Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kube-proxy's MetricsBindAddress configurable via flag #48625

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Make kube-proxy's MetricsBindAddress configurable via flag #48625

merged 1 commit into from
Jul 12, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jul 7, 2017 •
edited
Loading

What this PR does / why we need it: From #48600, MetricsBindAddress used to be configurable through flag (coupled with HealthzBindAddress). But this functionality went away after #44968 separated healthz server from metrics server. This PR adds that functionality back.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer:
/assign @ncdc
cc @bowei @r0bj

Release note:

The IP address and port for kube-proxy metrics server is now configurable via flag `--metrics-bind-address`

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 7, 2017
@ncdc
Copy link
Member

ncdc commented Jul 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Jul 7, 2017 •
edited
Loading

Thanks!

/assign @thockin
for approval.

@thockin
Copy link
Member

thockin commented Jul 7, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2017
@MrHohn MrHohn force-pushed the kube-proxy-metrics-flags branch from 6d45fd0 to a4e359a Compare July 7, 2017 19:46
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Jul 7, 2017

Sorry, updated bazel BUILD files.

@ncdc
Copy link
Member

ncdc commented Jul 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, ncdc, thockin

Associated issue: 48600

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn
Copy link
Member Author

MrHohn commented Jul 10, 2017

/retest

3 similar comments
@MrHohn
Copy link
Member Author

MrHohn commented Jul 10, 2017

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Jul 11, 2017

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Jul 11, 2017

/retest

@fejta
Copy link
Contributor

fejta commented Jul 11, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47232, 48625, 48613, 48567, 39173)

@k8s-github-robot k8s-github-robot merged commit d396ac5 into kubernetes:master Jul 12, 2017
@MrHohn MrHohn mentioned this pull request Jul 28, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 31, 2017
Merge pull request #49799 from MrHohn/automated-cherry-pick-of-#48625…
129cccd 
…-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #48625

Cherry pick of #48625 on release-1.7.

#48625: Make kube-proxy's MetricsBindAddress configurable via flag

**Release note**:

```release-note
The IP address and port for kube-proxy metrics server is now configurable via flag `--metrics-bind-address`

Special notice for kube-proxy in 1.7+ (including 1.7.0):
- Healthz server (/healthz) will be served on 0.0.0.0:10256 by default.
- Metrics server (/metrics and /proxyMode) will be served on 127.0.0.1:10249 by default.
- Metrics server will continue serving /healthz.
```
@MrHohn MrHohn deleted the kube-proxy-metrics-flags branch August 3, 2017 17:48
@MrHohn
Copy link
Member Author

MrHohn commented Aug 3, 2017

/release-note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 3, 2017
@MrHohn MrHohn mentioned this pull request Aug 3, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 3, 2017
Merge pull request #50104 from MrHohn/kube-proxy-1.7.3-changelog
04b2c29 
Automatic merge from submit-queue

Add kube-proxy change notice to v1.7.3 release note

**What this PR does / why we need it**: Add necessary release note for issue #48600.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48600 

**Special notes for your reviewer**:

This is suppose to be in v1.7.3 release note, but turned out I only updated release note on the cherrypick PR (#49799) instead of the original PR (#48625) so nothing got picked up :( 

/assign @bowei @wojtek-t 

**Release note**:

```release-note
NONE
```
@alexbrand
Copy link
Contributor

It seems like the reference configuration is missing the --metrics-bind-address option.

https://kubernetes.io/docs/admin/kube-proxy/

@MrHohn MrHohn mentioned this pull request Sep 25, 2017
Closed
2 tasks
@MrHohn
Copy link
Member Author

MrHohn commented Sep 25, 2017

@alexbrand Thanks for reporting. I opened kubernetes/website#5618 for tracking.

@alexbrand
Copy link
Contributor

Awesome! Thanks @MrHohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MrHohn @ncdc @thockin @k8s-github-robot @fejta @alexbrand @k8s-ci-robot