-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the memory request/limit for ip-masq-daemon. #47887
Conversation
/assign @dchen1107 |
cc/ @davidopp |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, dnardo Associated issue: 47865 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@@ -21,10 +21,10 @@ spec: | |||
resources: | |||
limits: | |||
cpu: 100m | |||
memory: 8Mi | |||
memory: 16Mi | |||
requests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question here, instead of bump the request here, why not just remove the request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnardo @dchen1107 hope can get some comments from you for this question even this is merged, thanks.
Automatic merge from submit-queue (batch tested with PRs 42252, 42251, 42249, 47512, 47887) |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #issue #47865
Special notes for your reviewer:
Release note: