Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the memory request/limit for ip-masq-daemon. #47887

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

dnardo
Copy link
Contributor

@dnardo dnardo commented Jun 22, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
issue #47865
Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2017
@dnardo
Copy link
Contributor Author

dnardo commented Jun 22, 2017

/assign @dchen1107

@dchen1107 dchen1107 added this to the v1.7 milestone Jun 22, 2017
@dchen1107 dchen1107 added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2017
@dchen1107
Copy link
Member

cc/ @davidopp

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dnardo

Associated issue: 47865

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2017
@@ -21,10 +21,10 @@ spec:
resources:
limits:
cpu: 100m
memory: 8Mi
memory: 16Mi
requests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question here, instead of bump the request here, why not just remove the request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnardo @dchen1107 hope can get some comments from you for this question even this is merged, thanks.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42252, 42251, 42249, 47512, 47887)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants