Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to kube-addon-manager:v6.4-beta.2: kubectl v1.6.4 and refreshed base images #47389

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Update to kube-addon-manager:v6.4-beta.2: kubectl v1.6.4 and refreshed base images #47389

merged 1 commit into from
Jun 14, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jun 13, 2017 •
edited
Loading

What this PR does / why we need it: refreshes base images for kube-addon-manager with fixes for CVE-2016-9841 and CVE-2016-9843.

x-ref #47386

Special notes for your reviewer: the updated images are not yet pushed, so tests will fail until that's done.

Release note:

/assign @MrHohn

@ixdy ixdy added this to the v1.7 milestone Jun 13, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 13, 2017
@ixdy
Copy link
Member Author

ixdy commented Jun 13, 2017

/release-note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 13, 2017
@MrHohn
Copy link
Member

MrHohn commented Jun 13, 2017

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017
@ixdy
Copy link
Member Author

ixdy commented Jun 13, 2017

/assign @roberthbailey

I'm going to push these images now

@roberthbailey
Copy link
Contributor

/lgtm

@roberthbailey
Copy link
Contributor

/approve

@roberthbailey
Copy link
Contributor

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, ixdy, roberthbailey

Associated issue: 47386

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2017
@ixdy
Copy link
Member Author

ixdy commented Jun 13, 2017

/retest

@ixdy ixdy mentioned this pull request Jun 13, 2017
Merged
@ixdy
Copy link
Member Author

ixdy commented Jun 13, 2017

ugh this test is the worst
/retest

@ixdy
Copy link
Member Author

ixdy commented Jun 14, 2017

/retest

1 similar comment
@ixdy
Copy link
Member Author

ixdy commented Jun 14, 2017

/retest

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47302, 47389, 47402, 47468, 47459)

@k8s-github-robot k8s-github-robot merged commit d898369 into kubernetes:master Jun 14, 2017
@k8s-ci-robot
Copy link
Contributor

@ixdy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 eddf98d link @k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot pushed a commit that referenced this pull request Jun 29, 2017
Merge pull request #47454 from ixdy/update-1.6-images
425b287 
Automatic merge from submit-queue

Refresh cluster-proportional-autoscaler, fluentd-gcp, kube-addon-manager, and kube-dns addons

**What this PR does / why we need it**: refreshes a number of addons with new base images:
* gcr.io/google-containers/cluster-proportional-autoscaler-amd64:1.1.1-r3 (rebuilt at 1.1.1)
* gcr.io/google-containers/fluentd-gcp:2.0.7 (kubernetes-retired/contrib#2633, kubernetes-retired/contrib#2640)
* gcr.io/google-containers/kube-addon-manager:v6.4-beta.2 (cherry-pick from #47389)
* gcr.io/google-containers/k8s-dns-*:1.14.4 (kubernetes/dns#107, kubernetes/dns#108, kubernetes/dns#114, kubernetes/dns#115)

These include upstream fixes to base images with fixes for the following CVEs:
* CVE-2016-9841
* CVE-2016-9843
* CVE-2017-2616
* CVE-2017-6512

Note: I did **not** update the fluentd-gcp version in `cluster/saltbase/salt/fluentd-gcp/fluentd-gcp.yaml`, which is currently 2.0.2. While there should be no functional changes 2.0.5 -> 2.0.7, I don't know about 2.0.2 -> 2.0.7. If we think this is safe, I can update that one too; otherwise, we may need to build a 2.0.2-r2 image.

**Release note**:

```release-note
Update cluster-proportional-autoscaler, fluentd-gcp, and kube-addon-manager, and kube-dns addons with refreshed base images containing fixes for CVE-2016-9841, CVE-2016-9843, CVE-2017-2616, and CVE-2017-6512.
```
/release-note
/assign @timstclair @enisoc 
/cc @MrHohn @crassirostris
@ixdy ixdy deleted the kube-addon-manager-update branch May 15, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

Assignees

@roberthbailey roberthbailey

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ixdy @MrHohn @roberthbailey @k8s-github-robot @k8s-ci-robot