HPA: only send updates when the status has changed #47078
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
cc @kubernetes/sig-autoscaling-pr-reviews @derekwaynecarr @liggitt @dak1n1 |
k8s-ci-robot
added
the
sig/autoscaling
DirectXMan12
force-pushed
the
bug/only-update-when-needed
branch
from
5c9df1f to
5c46438
Compare
|
To elaborate, the writes cause other side effects (like frequent snapshotting of etcd), which can have other side effects when trying to run and restore HA etcd deployments. Minimizing the write frequency is a priority. |
|
Does this bugfix target v1.7? |
|
@DirectXMan12 Aren't we always updating |
|
@luxas -- yes, i updated milestone. |
DirectXMan12
force-pushed
the
bug/only-update-when-needed
branch
from
5c46438 to
00a19f1
Compare
This commit only sends updates if the status has actually changed. Since the HPA runs at a regular interval, this should reduce the volume of writes, especially on short HPA intervals with relatively constant metrics.
We actually never update observed generation, AFAICT. |
|
/lgtm with this change, what amount of traffic should i expect per HPA in a steady state cluster environment? |
k8s-ci-robot
added
the
lgtm
|
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, derekwaynecarr Associated issue: 47077 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 46979, 47078, 47138, 46916) |
|
@DirectXMan12: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This commit only sends updates if the status has actually changed.
Since the HPA runs at a regular interval, this should reduce the volume
of writes, especially on short HPA intervals with relatively constant
metrics.
Fixes #47077
Release note: