Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Initializers from admission-control in kubernetes-master charm for pre-1.7 #46987

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Remove Initializers from admission-control in kubernetes-master charm for pre-1.7 #46987

merged 1 commit into from
Jun 8, 2017

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Jun 5, 2017 •
edited
Loading

What this PR does / why we need it:

This fixes a problem with the kubernetes-master charm where kube-apiserver never comes up:

failed to initialize admission: Unknown admission plugin: Initializers

The Initializers plugin does not exist before Kubernetes 1.7. The charm needs to support 1.6 as well.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47062

Special notes for your reviewer:

This fixes a problem introduced by #36721

Release note:

Remove Initializers from admission-control in kubernetes-master charm for pre-1.7

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 5, 2017
@lazypower
Copy link
Contributor

@k8s-bot /assign chuckbutler

@lazypower
Copy link
Contributor

/assign @chuckbutler

@lazypower
Copy link
Contributor

This is +1 LGTM. Thanks for catching this and turning around a fix so quickly.

/approve

@lazypower
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2017
@lazypower
Copy link
Contributor

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@Cynerva
Copy link
Contributor Author

Cynerva commented Jun 5, 2017

/retest

@lazypower
Copy link
Contributor

@mikedanese I think this qualifies for an exception during the CodeFreeze. it's an extra small submission but unbreaks us in tip/tags (if merged over). As it stands today an external contribution broke the juju charms in tip. We would like to have this land so we retain our support promise to our users of current version and current version -1.

We've run the gambit of tests and validated locally that things behave as expected.

Thanks for your consideration.

@lazypower lazypower mentioned this pull request Jun 6, 2017
Closed
@dchen1107
Copy link
Member

/approve

@lazypower
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, chuckbutler, dchen1107

Associated issue: 47062

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese mikedanese added this to the v1.7 milestone Jun 8, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e72c64b into kubernetes:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lazypower lazypower

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Juju charms fail deployment of 1.6 clusters with "Unknown admission controller: initializers"
6 participants
@Cynerva @k8s-ci-robot @lazypower @dchen1107 @k8s-github-robot @mikedanese