Hi @harryge00. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

cc @crassirostris

@harryge00 looks good and thank you, can you please add a release note for this? Exact syntax to update your description is here

@k8s-bot ok to test

@coffeepac I have added release notes

@harryge00 @coffeepac I think something like removing files should not be in the release notes. Release notes exist for the users to track behavior changes that might affect them. If that change doesn't change anything, then I personally think release notes are not necessary. Otherwise, the behavior changes should be described, not developer's actions, e.g. 'fluentd-elasticsearch deployment index schema template is now set up by Elasticsearch'

@harryge00 does removing this file changes the behavior?

@coffeepac do you agree?

@harryge00 thank you!

@crassirostris the file may be used be someone who has built some automation around using this file. that automation would break. if that bar is too low then adding the no-op release note is fine with me. we do need something in the release note or the merge bot won't merge it.

@coffeepac It's possible to add release-notes-none label

@crassirostris so it can be. good to know. I was letting @harryge00 decide if there should be an actual note or a no-note.

I'm fine either way, this doesn't affect the behavior of the specified version of ES.

Thanks!

I agree that the removal does not affect Elasticsearch behavior, whose version is later than v2.0.0-beta1 . @coffeepac @crassirostris

If someone has built some auomation around this file, they should have their own fork, because they also need a script in this es-image to do automation. Adding a script, which automatically loads this template, is a possible way to solve #25127. But it is a bit hacky, we have to check the elasticsearch is ready and then curl elasticsearch API to load it, with retries...

@harryge00 okay, then no release is preferred. can you please either remove the release note I asked you to add or replace it with NONE?

@coffeepac updated

/lgtm /approve

lgtm

/lgtm

We'll look into the problem

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, crassirostris, harryge00

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue (batch tested with PRs 46201, 45952, 45427, 46247, 46062)

@harryge00: The following test(s) failed:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.