Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gophercloud/gophercloud dependency #45545

Merged
merged 3 commits into from
Jun 13, 2017
Merged

update gophercloud/gophercloud dependency #45545

merged 3 commits into from
Jun 13, 2017

Conversation

stuart-warren
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes
fixes #44461

Special notes for your reviewer:

Release note:

update gophercloud/gophercloud dependency for reauthentication fixes

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @stuart-warren. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2017
@stuart-warren
Copy link
Contributor Author

I've really signed the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 19, 2017
@mikebryant
Copy link
Contributor

ping @jbeda @lavalamp
Could we get LGTM / ok to test / approval please?

@BugRoger BugRoger mentioned this pull request May 23, 2017
Closed
@dims
Copy link
Member

dims commented Jun 1, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2017
@dims
Copy link
Member

dims commented Jun 2, 2017

@stuart-warren - Do you have some time to freshen up this patch? Thanks!

@dims
Copy link
Member

dims commented Jun 3, 2017

/assign

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2017
@stuart-warren
Copy link
Contributor Author

@dims done I believe
Updating deps is a pain :(

@dims
Copy link
Member

dims commented Jun 6, 2017

@stuart-warren yes that it is!!! thanks

@dims
Copy link
Member

dims commented Jun 6, 2017

@jbeda @lavalamp - is it appropriate to update dependencies at this stage in the game? Thanks!

/unassign

@marun marun added the kind/bug Categorizes issue or PR as related to a bug. label Jun 9, 2017
@dims dims mentioned this pull request Jun 9, 2017
Closed
@dims
Copy link
Member

dims commented Jun 9, 2017

@dchen1107 - yes, let us please merge this PR for 1.7 (on behalf of sig-openstack)

@anguslees
Copy link
Member

anguslees commented Jun 10, 2017 •
edited
Loading

/lgtm

Yes, we need this cherrypicked or the openstack cloud provider is going to be basically unusable for 1.7 (at least, after it's been running for 12h).

You can see from the vendor/ diffs that the only changes are 1) the desired gophercloud auth_options.go fix, and 2) some harmless additions of new gophercloud constants in requests.go. This is a very targeted vendor/ update.

@dchen1107 dchen1107 added this to the v1.7 milestone Jun 12, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, dchen1107, stuart-warren

Associated issue: 44461

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2017
@mikebryant
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46678, 45545, 47375)

@k8s-github-robot k8s-github-robot merged commit 456293b into kubernetes:master Jun 13, 2017
@dims dims mentioned this pull request Jun 13, 2017
Closed
@mikebryant mikebryant deleted the 44461-gophercloud-bump branch June 27, 2017 10:10
dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018
Merge pull request kubernetes#45545 from ocadotechnology/44461-gopher…
bc6ffde 
…cloud-bump

Automatic merge from submit-queue (batch tested with PRs 46678, 45545, 47375)

update gophercloud/gophercloud dependency

**What this PR does / why we need it**:

**Which issue this PR fixes** 
fixes kubernetes#44461

**Special notes for your reviewer**:

**Release note**:

```release-note
update gophercloud/gophercloud dependency for reauthentication fixes
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradbeam bradbeam bradbeam approved these changes

Assignees

@jbeda jbeda

@lavalamp lavalamp

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

openstack cloud provider fails to reauthenticate