Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Allow configuration of a single security group for ELBs #45500

Merged
merged 2 commits into from
Jun 3, 2017
Merged

AWS: Allow configuration of a single security group for ELBs #45500

merged 2 commits into from
Jun 3, 2017

Conversation

nbutton23
Copy link
Contributor

@nbutton23 nbutton23 commented May 8, 2017 •
edited
Loading

What this PR does / why we need it:
AWS has a hard limit on the number of Security Groups (500). Right now every time an ELB is created Kubernetes is creating a new Security Group. This allows for specifying a Security Group to use for all ELBS

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
For some reason the Diff tool makes this look like it was way more changes than it really was.
Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @nbutton23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels May 8, 2017
@nbutton23
Copy link
Contributor Author

@justinsb You asked me to tag you in this PR

@justinsb justinsb mentioned this pull request Jun 1, 2017
Merged
@justinsb
Copy link
Member

justinsb commented Jun 1, 2017

@k8s-bot ok to test

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, nbutton23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 1, 2017
@justinsb justinsb changed the title Nbutton aws elb security group AWS: Allow configuration of a single security group for ELBs Jun 1, 2017
@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 1, 2017
@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 36721, 46483, 45500, 46724, 46036)

@k8s-github-robot k8s-github-robot merged commit 4220b73 into kubernetes:master Jun 3, 2017
@dlsniper
Copy link

Just a small comment about an inaccuracy from the PR. AWS has a default, soft-limit, of 500 security groups. While I'm sure there's a hard limit somewhere, I couldn't find the docs for it.

Here's the link to the documentation regarding this: http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_Appendix_Limits.html#vpc-limits-security-groups

@nbutton23
Copy link
Contributor Author

nbutton23 commented Jun 12, 2017 •
edited
Loading

@dlsniper Interesting. . . Our AWS concierge told us it was a hard limit for performance reasons. . .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@nbutton23 @k8s-ci-robot @k8s-reviewable @justinsb @k8s-github-robot @dlsniper @calebamiles @jsafrane