-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(golang.org/x/oauth2): a6bd8cefa1811bd24b86f8902872e4e8225f74c4 #45056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Apr 27, 2017
k8s-github-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
release-note-label-needed
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
release-note-label-needed
labels
Apr 27, 2017
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericchiang, smarterclayton
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Apr 28, 2017
ericchiang
force-pushed
the
update-oauth2
branch
from
April 28, 2017 20:20
82d9bf5
to
0b54919
Compare
adding |
calebamiles
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
May 4, 2017
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I tackle #42654 kubectl's OpenID Connect plugin will start using golang.org/x/oauth2 for refreshing, instead of go-oidc's own hand rolled oauth2 implementation. In preparation, update golang.org/x/oauth2 to include golang/oauth2@7374b3f which fixes refreshing with Okta.
We also somehow removed the dependency on
google.golang.org/appengine
. Maybe golang/oauth2@8cf5815?cc @kubernetes/sig-auth-pr-reviews