Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GLBC version to 0.9.3 #45055

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Bump GLBC version to 0.9.3 #45055

merged 1 commit into from
Apr 28, 2017

Conversation

nicksardo
Copy link
Contributor

What this PR does / why we need it:
Bumps version of GLBC shipped with K8s
https://github.com/kubernetes/ingress/releases/tag/0.9.3

Major Changelog:

Bug fix: adding backends to existing backend-services #652
Bug fix: handling of secret-based SSL Certs #639
Add second LB healthcheck/proxy traffic source CIDR #574 #479
Support backside re-encryption (HTTPS) #519

The two noted bugs are common occurrences for GKE users

Release note:

Bump GLBC version to 0.9.3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 27, 2017
@nicksardo
Copy link
Contributor Author

/assign @zmerlynn

@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, nicksardo

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2017
mikedanese
mikedanese reviewed Apr 27, 2017
View reviewed changes
cluster/saltbase/salt/l7-gcp/glbc.manifest
@@ -43,7 +43,7 @@ spec:
# TODO: split this out into args when we no longer need to pipe stdout to a file #6428
- sh
- -c
- '/glbc --verbose=true --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1'
- '/glbc --verbose=true --apiserver-host=http://localhost:8080 --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we no longer default to localhost except with kubectl, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, previously was using deprecated clientcmd.ClusterDefaults https://github.com/kubernetes/client-go/blob/670b68600ead2fdd5c835a9ff7239dda903640a6/tools/clientcmd/client_config.go#L49
This flag is identical to the one used for nginx ingress controller.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5097971 into kubernetes:master Apr 28, 2017
@nicksardo
Copy link
Contributor Author

@mikedanese I'd like to cherrypick this to 1.6/1.5/1.4. Can you apply the cherrypick-candidate label and set the 1.7 milestone, please?

@mikedanese mikedanese modified the milestones: v1.6, v1.7 Apr 28, 2017
@mikedanese mikedanese assigned bowei and unassigned zmerlynn and eparis Apr 28, 2017
This was referenced Apr 28, 2017
Merged
Merged
Closed
k8s-github-robot pushed a commit that referenced this pull request May 1, 2017
Merge pull request #45069 from nicksardo/automated-cherry-pick-of-#45…
23f42e9 
…055-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #45055

Cherry pick of #45055 on release-1.5.

#45055: Bump GLBC version to 0.9.3

**Release note**:
```release-note
Bump GLBC version to 0.9.3
```
k8s-github-robot pushed a commit that referenced this pull request May 9, 2017
Merge pull request #45068 from nicksardo/automated-cherry-pick-of-#45…
8118c50 
…055-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #45055

Cherry pick of #45055 on release-1.6.

#45055: Bump GLBC version to 0.9.3

**Release note**:
```release-note
Bump GLBC version to 0.9.3
```
@nicksardo nicksardo deleted the glbc-v0.9.3-bump branch January 12, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

Assignees

@bowei bowei

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@nicksardo @k8s-reviewable @mikedanese @k8s-github-robot @bowei @zmerlynn @dchen1107 @eparis @k8s-ci-robot