Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API discovery docs do not provide ETag information for clients #44957

Closed
smarterclayton opened this issue Apr 26, 2017 · 7 comments
Closed

API discovery docs do not provide ETag information for clients #44957

smarterclayton opened this issue Apr 26, 2017 · 7 comments
Assignees
@mbohlool
Labels
area/usability lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@smarterclayton
Copy link
Contributor

We implemented "re-discovery" if the resource name doesn't match one we know:

kubectl get posd  # <-- triggers full rediscovery
  1. Unfortunately, this means that having a typo here will now always take >2-5s to resolve (if you're on a slow connection, it could be minutes).
  2. If you typo twice in a row, you download all discovery docs twice (the odds of this actually helping are almost zero)
  3. We don't have etag or "if not modified" checks on these resources... so the user has to download them every time and they are not small
  4. We get rate limited by the client (throttled client side) when we download these - which means when you have lots of groups we get even slower.

We need to be smarter, this is very annoying even when latency is 0.
@smarterclayton smarterclayton added area/usability sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Apr 26, 2017
@smarterclayton
Copy link
Contributor Author

@kubernetes/sig-cli-bugs

@liggitt liggitt added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 29, 2017
@liggitt
Copy link
Member

liggitt commented Jun 29, 2017

cc @kubernetes/sig-api-machinery-feature-requests

@liggitt liggitt changed the title Reloading of discovery docs on bad resource name is... not a great experience API discovery docs do not provide ETag information for clients Jun 29, 2017
@liggitt liggitt mentioned this issue Jun 29, 2017
Closed
@mbohlool mbohlool mentioned this issue Jun 29, 2017
Closed
@sttts
Copy link
Contributor

sttts commented Jul 3, 2017

  1. We have one discovery request per api group. It could be one, with one eTag.

@lavalamp
Copy link
Member

/assign @mbohlool

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@jessesuen jessesuen mentioned this issue May 8, 2018
Closed
@lingsamuel lingsamuel mentioned this issue Nov 18, 2020
Closed
@ardaguclu ardaguclu mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbohlool mbohlool

Labels
area/usability lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lavalamp @sttts @liggitt @smarterclayton @mbohlool @k8s-ci-robot @fejta-bot