Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify subnetid and routetableid via cloud provider config #44235

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Specify subnetid and routetableid via cloud provider config #44235

merged 1 commit into from
Apr 8, 2017

Conversation

mrIncompetent
Copy link
Contributor

What this PR does / why we need it:
This is a fix for #39996 which is needed since 1.6

Changes introduced from 1.6 broke partially(LoadBalancer) the support for running the master components in a different environment (different aws account/on premise). This PR will add support for specifying the Subnet & RouteTable to use via the cloud provider config.

Release note:

AWS cloud provider: fix support running the master with a different AWS account or even on a different cloud provider than the nodes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @mrIncompetent. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 8, 2017
@mrIncompetent mrIncompetent mentioned this pull request Apr 8, 2017
Closed
@sttts
Copy link
Contributor

sttts commented Apr 8, 2017

@k8s-bot ok to test

justinsb
justinsb approved these changes Apr 8, 2017
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinsb
Copy link
Member

justinsb commented Apr 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mrIncompetent

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 41e9b80 into kubernetes:master Apr 8, 2017
@mrIncompetent mrIncompetent deleted the feature/configurable-aws-subnetid-routetableid branch April 8, 2017 18:25
@k8s-ci-robot
Copy link
Contributor

@mrIncompetent: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCI GCE e2e 1c1f02f link @k8s-bot gci gce e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts sttts added this to the v1.6 milestone Apr 10, 2017
@mrIncompetent mrIncompetent mentioned this pull request Apr 10, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 10, 2017
Merge pull request #44264 from kubermatic/automated-cherry-pick-of-#4…
6a0eb4a 
…4235-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #44235

Cherry pick of #44235 on release-1.6.

#44235: Specify subnetid and routetableid via cloud provider config
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#44264 from kubermatic/automated-cherry-…
8e1e83c 
…pick-of-#44235-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of kubernetes#44235

Cherry pick of kubernetes#44235 on release-1.6.

kubernetes#44235: Specify subnetid and routetableid via cloud provider config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb approved these changes

Assignees

@justinsb justinsb

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@mrIncompetent @k8s-reviewable @k8s-ci-robot @sttts @justinsb @k8s-github-robot @k8s-cherrypick-bot @zmerlynn