Remove the deprecated --babysit-daemons kubelet flag #44230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaufen
added
area/kubelet
area/kubelet-api
sig/node
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
kind/api-change
|
This change is |
|
@justinsb FYI kops change needed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
ping @justinsb do you have time to look into removing this flag for kops/fixing the failure? |
k8s-github-robot
added
the
needs-rebase
mtaufen
force-pushed
the
remove-babysit-daemons
branch
from
0e73432 to
31f2b7e
Compare
|
Rebased |
k8s-github-robot
added
size/S
mtaufen
force-pushed
the
remove-babysit-daemons
branch
from
31f2b7e to
2ee2ec5
Compare
|
rebased, re-adding lgtm label |
mtaufen
added
the
lgtm
mtaufen
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, mtaufen, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag has been deprecated for over a year (git blame says marked deprecated on March 1, 2016).
Relatively easy removal - nothing in the Kubelet relies on it anymore.
There was still some stuff in the provisioning scripts. It was easy to rip out, but in general we probably need to be more disciplined about updating the provisioning scripts at the same time that we initially mark things deprecated.