Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go1.8.1 for arm and ppc64le #44216

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Use go1.8.1 for arm and ppc64le #44216

merged 1 commit into from
Apr 8, 2017

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Apr 7, 2017

What this PR does / why we need it:
This PR is for moving from 1.8 rc2 version to 1.8.1 for cross compiling platform like ppc64le and arm.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @mkumatag. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkumatag
Copy link
Member Author

mkumatag commented Apr 7, 2017

/cc @ixdy @luxas

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 7, 2017
@mkumatag mkumatag mentioned this pull request Apr 7, 2017
Closed
@luxas luxas added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 7, 2017
@luxas luxas assigned ixdy and unassigned lavalamp Apr 7, 2017
luxas
luxas reviewed Apr 7, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ixdy please push the image

@ixdy ixdy changed the title Bump K8S_GOLANG_EDGE_VERSION to 1.8.1 Build arm and ppc64le using go1.8.1. Apr 7, 2017
@ixdy ixdy added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 7, 2017
@ixdy
Copy link
Member

ixdy commented Apr 7, 2017

/lgtm

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mkumatag

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2017
@ixdy ixdy changed the title Build arm and ppc64le using go1.8.1. Use go1.8.1 for arm and ppc64le Apr 7, 2017
@ixdy
Copy link
Member

ixdy commented Apr 7, 2017

hm, I would've expected this to trigger cross-build too.
@k8s-bot build this

@ixdy
Copy link
Member

ixdy commented Apr 7, 2017

@k8s-bot pull-kubernetes-cross test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 30c6758 into kubernetes:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas left review comments

Assignees

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkumatag @k8s-reviewable @k8s-ci-robot @ixdy @k8s-github-robot @luxas @lavalamp