Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow swapping NotReady and Unschedulable Taints #44042

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Allow swapping NotReady and Unschedulable Taints #44042

merged 1 commit into from
Apr 6, 2017

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Apr 4, 2017 •
edited by enisoc
Loading

Fix #43444

cc @kubernetes/sig-scheduling-pr-reviews @davidopp @aveshagarwal @mdshuai

For cherrypick @ethernetdan

Fix [transition between NotReady and Unreachable taints](https://github.com/kubernetes/kubernetes/issues/43444).

@gmarek gmarek added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Apr 4, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2017
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-ci-robot
Copy link
Contributor

@gmarek: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins non-CRI GCE e2e 576ad81 link @k8s-bot non-cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gmarek
Copy link
Contributor Author

gmarek commented Apr 6, 2017

Ping @davidopp @aveshagarwal

@aveshagarwal
Copy link
Member

@gmarek, will review today, thanks.

@aveshagarwal
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, gmarek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42961, 44042)

@k8s-github-robot k8s-github-robot merged commit aead989 into kubernetes:master Apr 6, 2017
@davidopp
Copy link
Member

davidopp commented Apr 7, 2017

Thanks @gmarek !

@gmarek gmarek added this to the v1.6.1 milestone Apr 10, 2017
@gmarek gmarek mentioned this pull request Apr 10, 2017
Merged
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

k8s-github-robot pushed a commit that referenced this pull request Apr 10, 2017
Merge pull request #44266 from gmarek/automated-cherry-pick-of-#44042…
85b9c96 
…-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #44042

Cherry pick of #44042 on release-1.6.

#44042: Allow swapping NotReady and Unschedulable Taints

```release-note
Fix [transition between NotReady and Unreachable taints](#43444).
```
@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 13, 2017
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#44266 from gmarek/automated-cherry-pick…
f7e25fa 
…-of-#44042-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of kubernetes#44042

Cherry pick of kubernetes#44042 on release-1.6.

kubernetes#44042: Allow swapping NotReady and Unschedulable Taints

```release-note
Fix [transition between NotReady and Unreachable taints](kubernetes#43444).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aveshagarwal aveshagarwal

@davidopp davidopp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gmarek @k8s-reviewable @k8s-cherrypick-bot @k8s-ci-robot @aveshagarwal @k8s-github-robot @davidopp @enisoc @ingvagabund