Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: reduce polling delay for all Azure clients #43699

Merged
merged 3 commits into from
Mar 29, 2017

Conversation

colemickens
Copy link
Contributor

@colemickens colemickens commented Mar 27, 2017

What this PR does / why we need it: Reduces the polling delay for all azure clients to 5 seconds. This should speed up some additional operations at the cost of some quota.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): n/a

Special notes for your reviewer: This stacks on top of #43697, please only look at latest commit. Alternatively I can rebase this on top of master.

Release note:

Azure cloudprovider: Reduce the polling delay for all azure clients to 5 seconds. This should speed up some operations at the cost of some additional quota.

I don't think the StorageClient polls anywhere, and it's a different type of client, so I didn't touch it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@brendandburns
Copy link
Contributor

needs update-bazel.sh

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2017
@colemickens
Copy link
Contributor Author

@k8s-bot bazel test this

@colemickens
Copy link
Contributor Author

@k8s-bot verify test this

@colemickens
Copy link
Contributor Author

cc: @brendandburns @smarterclayton Everything's green, just need an LGTM. Thanks.

@brendandburns
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, colemickens

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41135, 43699)

@k8s-github-robot k8s-github-robot merged commit f00d371 into kubernetes:master Mar 29, 2017
k8s-github-robot pushed a commit that referenced this pull request Apr 12, 2017
…43699-kubernetes-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #43699

Cherry pick of #43699 on release-1.6.

#43699: azure: add k8s info to user-agent string

```release-note
Azure cloudprovider: Reduce the polling delay for all azure clients to 5 seconds. This should speed up some operations at the cost of some additional quota.
```
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
…-pick-of-#43699-kubernetes-release-1.6

Automatic merge from submit-queue

Automated cherry pick of kubernetes#43699

Cherry pick of kubernetes#43699 on release-1.6.

kubernetes#43699: azure: add k8s info to user-agent string

```release-note
Azure cloudprovider: Reduce the polling delay for all azure clients to 5 seconds. This should speed up some operations at the cost of some additional quota.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants