Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable audit log in local cluster #42379

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Enable audit log in local cluster #42379

merged 1 commit into from
Mar 31, 2017

Conversation

xilabao
Copy link
Contributor

@xilabao xilabao commented Mar 2, 2017 •
edited
Loading

fixes #42318

ENABLE_APISERVER_BASIC_AUDIT=true hack/local-up-cluster.sh

@k8s-ci-robot
Copy link
Contributor

Hi @xilabao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2017
@k82cn
Copy link
Member

k82cn commented Mar 2, 2017

@k8s-bot ok to test

@k82cn
Copy link
Member

k82cn commented Mar 2, 2017

@xilabao , please update "ref to #42318" to "fixes #42318"; so the k8s-bot will close the issue when this PR merged.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Mar 2, 2017
@xilabao
Copy link
Contributor Author

xilabao commented Mar 2, 2017

@k82cn Thanks for your reminding. updated

@xilabao
Copy link
Contributor Author

xilabao commented Mar 2, 2017

@k8s-bot gci gke e2e test this
@k8s-bot cvm gke e2e test this

gyliu513
gyliu513 reviewed Mar 2, 2017
View reviewed changes
hack/local-up-cluster.sh Outdated
@@ -713,6 +733,7 @@ Local Kubernetes cluster is running. Press Ctrl-C to shut it down.

Logs:
${APISERVER_LOG:-}
${APISERVER_BASIC_AUDIT_LOG:-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not printed this if not enabling the audit log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@gyliu513
Copy link
Contributor

gyliu513 commented Mar 2, 2017 •
edited
Loading

ENABLE_APISERVER_BASIC_AUDIT=true ENABLE_RBAC=true hack/local-up-cluster.sh

Why need enable RBAC for this? @xilabao

@k8s-reviewable
Copy link

This change is Reviewable

@xilabao xilabao force-pushed the enable-audit-log-in-local-cluster branch from 4a9a057 to 183fd62 Compare March 2, 2017 09:06
gyliu513
gyliu513 reviewed Mar 2, 2017
View reviewed changes
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks @xilabao

@xilabao
Copy link
Contributor Author

xilabao commented Mar 2, 2017

@k8s-bot gci gke e2e test this
@k8s-bot cvm gke e2e test this
@k8s-bot cvm gce e2e test this

1 similar comment
@xilabao
Copy link
Contributor Author

xilabao commented Mar 3, 2017

@k8s-bot gci gke e2e test this
@k8s-bot cvm gke e2e test this
@k8s-bot cvm gce e2e test this

@xilabao
Copy link
Contributor Author

xilabao commented Mar 3, 2017

@k8s-bot gci gke e2e test this

2 similar comments
@xilabao
Copy link
Contributor Author

xilabao commented Mar 3, 2017

@k8s-bot gci gke e2e test this

@xilabao
Copy link
Contributor Author

xilabao commented Mar 6, 2017

@k8s-bot gci gke e2e test this

@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Mar 7, 2017
@zmerlynn
Copy link
Member

zmerlynn commented Mar 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: xilabao, zmerlynn

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @fejta
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2017
@k82cn
Copy link
Member

k82cn commented Mar 12, 2017

@k8s-bot gce etcd3 e2e test this

@xilabao
Copy link
Contributor Author

xilabao commented Mar 30, 2017

@k8s-bot kubemark e2e test this

@xilabao
Copy link
Contributor Author

xilabao commented Mar 31, 2017

@k8s-bot unit test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42379, 42668, 42876, 41473, 43260)

@k8s-github-robot k8s-github-robot merged commit 2179ffe into kubernetes:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyliu513 gyliu513 gyliu513 left review comments

Assignees

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable audit log for hack/local-up-cluster.sh
7 participants
@xilabao @k8s-ci-robot @k82cn @gyliu513 @k8s-reviewable @zmerlynn @k8s-github-robot