This change is 

@colemickens @brendandburns

Why do you add the secret here? You didn't do this for the AzureDisk dynamic provisioner did you?

@colemickens right, for azure disk, no secret is needed in Azure API.

Azure file is different, it needs a username (i.e. storageaccountname in secret) and password (i.e. storageaccountkey in secret) to mount a CIFS share. When we create an Azure file share for a PVC, we have to ensure the secret is in the PVC's namespace so when Pod picks the PVC, the secret used by the PV exists.

@kubernetes/sig-storage-misc

I think I understand: AzureDisk needs the user/pass for Storage too, but those values are used by k-c-m which has access to the Azure cloudprovider auth context. On the other hand, for AzureFiles, the user/pass is used directly by mount under kubelet where you might not have access to the cloudprovider.

Is that the gist?

@colemickens yes, that's the idea.

Looks good to me. Thanks @rootfs.

@saad-ali PTAL, thanks

/assign @colemickens

/lgtm

@k8s-bot cvm gce e2e test this

/approve

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: brendandburns, colemickens, rootfs

Needs approval from an approver in each of these OWNERS Files:

• cmd/kube-controller-manager/OWNERS [brendandburns]
• examples/OWNERS [brendandburns]
• pkg/cloudprovider/providers/azure/OWNERS [brendandburns,colemickens]
• pkg/volume/azure_file/OWNERS [brendandburns,rootfs]

We suggest the following people:
cc
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-bot unit test this

Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)

@rootfs PR needs rebase