Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure only 1 Swift URL is used in cluster operations #41561

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Ensure only 1 Swift URL is used in cluster operations #41561

merged 1 commit into from
Apr 12, 2017

Conversation

jamiehannaford
Copy link
Contributor

What this PR does / why we need it:

Extracts only 1 Swift URL if multiple are returned from Keystone.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

#34930

Special notes for your reviewer:

Release note:

Heat cluster operations now support environments that have multiple Swift URLs

@k8s-ci-robot
Copy link
Contributor

Hi @jamiehannaford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 16, 2017
@roberthbailey
Copy link
Contributor

roberthbailey commented Feb 17, 2017 •
edited by mikedanese
Loading

/lgtm
/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2017
@jamiehannaford
Copy link
Contributor Author

What's the status of this?

@roberthbailey
Copy link
Contributor

The submit queue is only merging PRs that are marked as part of the 1.6 release. If you feel that this PR should be included in the 1.6 release (e.g. fixes a bug), you can petition @calebamiles to add the label to this PR. Otherwise, it will merge to the master branch once it opens back up for new PRs.

@jamiehannaford
Copy link
Contributor Author

@k8s-bot gci gce e2e test this

@k8s-ci-robot
Copy link
Contributor

@jamiehannaford: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot gci gce e2e test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jamiehannaford
Copy link
Contributor Author

@roberthbailey Would you mind running @k8s-bot ok to test? There seems to be a flaky test case

@roberthbailey
Copy link
Contributor

@k8s-bot ok to test

@jamiehannaford
Copy link
Contributor Author

@k8s-bot non-cri e2e test this

@jamiehannaford
Copy link
Contributor Author

@roberthbailey All tests are now passing 👍

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jamiehannaford, roberthbailey

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 750d5c3 into kubernetes:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamiehannaford @k8s-ci-robot @k8s-reviewable @roberthbailey @k8s-github-robot