Skip to content

client-gen tag shortcomings when newline is omitted #53893

@antoineco

Description

@antoineco

client-gen does not generate the content of typed/<group>/<version>/<group>_client.go / typed/<group>/<version>/generated_expansion.go when there is no new line between the // +genclient tag and the next struct.

How to reproduce:

works

// +genclient
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

type Foo struct {

fails

// +genclient
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
type Foo struct {

See also:

https://kubernetes.slack.com/archives/C0EG7JC6T/p1507887214000200

/kind bug
/sig api-machinery

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions