Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the replaceKeys and setElementOrder code in strategic merge patch #46543

Closed
mengqiy opened this issue May 26, 2017 · 8 comments
Closed

Cleanup the replaceKeys and setElementOrder code in strategic merge patch #46543

mengqiy opened this issue May 26, 2017 · 8 comments
Assignees
@mengqiy
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@mengqiy
Copy link
Member

mengqiy commented May 26, 2017 •
edited
Loading

Comments in replaceKeys:

Comments in setElementOrder:
https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/45980#-KlQrynxqa6fwPdcLbeh
https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/45980#-KlQsAHkxPOz_MIUFler
https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/45980#-KlQn7QltA-Wkwh6Q_aN

These comments are all about code style and refactoring.
@mengqiy
Copy link
Member Author

mengqiy commented May 26, 2017

/assign

@mengqiy mengqiy mentioned this issue May 26, 2017
Merged
@grodrigues3
Copy link
Contributor

@mengqiy can you please add sig labels to issues you create?

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 26, 2017
@mengqiy
Copy link
Member Author

mengqiy commented May 30, 2017

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label May 30, 2017
@mengqiy mengqiy changed the title Cleanup the replaceKeys code in strategic merge patch Cleanup the replaceKeys and setElementOrder code in strategic merge patch May 31, 2017
@mengqiy mengqiy mentioned this issue May 31, 2017
Merged
@caesarxuchao caesarxuchao removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 9, 2017
@caesarxuchao
Copy link
Member

Can we close this issue @mengqiy

@mengqiy
Copy link
Member Author

mengqiy commented Aug 10, 2017

Probably not. Please leave it open. I will address it when I have some cycles.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 7, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengqiy mengqiy

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mengqiy @caesarxuchao @grodrigues3 @k8s-ci-robot @fejta-bot