Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kernel version check for kubeadm upgrade #3114

Open
pacoxu opened this issue Sep 23, 2024 · 7 comments
Open

add kernel version check for kubeadm upgrade #3114

pacoxu opened this issue Sep 23, 2024 · 7 comments
Assignees
@pacoxu
Labels
area/preflight area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.33

Comments

@pacoxu
Copy link
Member

pacoxu commented Sep 23, 2024

Currently, only root check and corefile migration check before upgrading node.

// RunRootCheckOnly initializes checks slice of structs and call RunChecks
func RunRootCheckOnly(ignorePreflightErrors sets.Set[string]) error {
	checks := []Checker{
		IsPrivilegedUserCheck{},
	}

	return RunChecks(checks, os.Stderr, ignorePreflightErrors)
}

xref kubernetes/kubernetes#102612 (comment)
@neolit123
Copy link
Member

neolit123 commented Sep 24, 2024 •
edited
Loading

+1

in upgrade apply and upgrade node preflight we run RunRootCheckOnly, which should be changed to maybe a new RunUpgradeCheks func with what is needed.

then if RunRootCheckOnly is no longer used anywhere it can be removed.

@neolit123 neolit123 added area/upgrades kind/feature Categorizes issue or PR as related to a new feature. area/preflight priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 24, 2024
@neolit123 neolit123 added this to the v1.32 milestone Sep 24, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Sep 24, 2024

I did a quick check for all preflight checks.

  • Currently, we may only add to SystemVerificationCheck to RunUpgradeCheks.

@pacoxu
Copy link
Member Author

pacoxu commented Sep 24, 2024

BTW, should this update be done after bumping https://github.com/kubernetes/system-validators/ or not a problem?

@neolit123
Copy link
Member

running the kernel checks on upgrade can be done regardless.

also, i think bumping system validators should be done only after is done:

@neolit123
Copy link
Member

neolit123 commented Oct 17, 2024 •
edited
Loading

@pacoxu do you still have plans for this for 1.32?
it does not depend on the https://github.com/kubernetes/system-validators/releases/tag/v1.9.0

@pacoxu
Copy link
Member Author

pacoxu commented Oct 17, 2024

I will take a look later after some my ongoing tasks.

@pacoxu
Copy link
Member Author

pacoxu commented Oct 17, 2024

/assign
I think I may have some time in this release cycle.

@neolit123 neolit123 modified the milestones: v1.32, v1.33 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacoxu pacoxu

Labels
area/preflight area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.33
Development

No branches or pull requests
2 participants
@neolit123 @pacoxu